Upgrade to Vue 3#48
Open
semiaddict wants to merge 10 commits into
Open
Conversation
This is mostly important when teleporting a component to another window/iframe
Collaborator
Author
Revert a change to use navigator.platform instead of navigator.userAgentData.platform, as userAgentData is not supported by all major browsers.
Use KeyboardEvent.key instead. Closes: Dafrok#39
This allows contextualized hotkeys.
|
@Dafrok any chance you can merge this or add a maintainer? Happy to help if needed! |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades the entire package to work with Vue 3, and replaces the usage of the deprecated KeyboardEvent.keycode property by KeyboardEvent.key.
Since Vue 3 is now officially out and the default at vuejs.org, it might be interesting to move the original master branch to a vue2 branch, and make the version in the PR the default one.
Closes #31, #39