Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : Mgramseva expense stream incremental #115

Conversation

avirajsingh7
Copy link

No description provided.

@@ -7,6 +7,9 @@
},
"data": {
"type": "object"
},
"toDate":{
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we must have cursor field in schema

@@ -234,8 +237,20 @@ def __init__(
self.request_info = request_info
self.user_request = user_request
self.tenantid_list = tenantid_list
self.fromdate = fromdate
self.todate = todate
self.fromdate = fromdate.replace(hour=0, minute=0, second=0, microsecond=0)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to fetch record on month basis

@fatchat
Copy link

fatchat commented Jan 27, 2025

not merging yet, we have the following doubts:

  • at what point in the current month are the expenses made available
  • do all expenses appear on one date i.e. if we get a non-empty response for the current month, do we need to query the month again
  • when we switch to append/dedup, we need the id field to not be dependent on the toDate

Important: This command can only be run by one of the repository admins:
Usage: ./tools/bin/get_repo_admins.sh <personal_access_token>

@avirajsingh7
Copy link
Author

avirajsingh7 commented Feb 6, 2025

@fatchat We can close this for now, as we are now fetching records differently using the new CDK. However, this can be kept as a reference for future use once we receive an answer to the above question

Important: This command can only be run by one of the repository admins:
Usage: ./tools/bin/get_repo_admins.sh <personal_access_token>

@fatchat fatchat closed this Feb 6, 2025
@fatchat fatchat deleted the feat/mgram/expense-stream-incremental branch February 12, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants