Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include_archived as a config setting #119

Merged
merged 3 commits into from
Feb 14, 2025
Merged

include_archived as a config setting #119

merged 3 commits into from
Feb 14, 2025
+66 −5

Conversation

fatchat
Copy link

@fatchat fatchat commented Feb 14, 2025

What

Added a new config setting include_archived

How

  • Added the flag to spec.yaml
  • Pass it to Form constructors in generate_streams
  • The Form object saves it as a local variable
  • This is then passed to Commcare in Form.request_params

Review guide

source.py

User Impact

The default value of this setting is False

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@fatchat fatchat linked an issue Feb 14, 2025 that may be closed by this pull request
Make the flag "include_archived" configurable #118
Closed
@fatchat fatchat requested a review from Ishankoradia February 14, 2025 01:59
@Ishankoradia Ishankoradia merged commit b85e77f into prod/commcare Feb 14, 2025
10 of 16 checks passed
@Ishankoradia Ishankoradia deleted the 118-make-the-flag-include_archived-configurable branch February 14, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ishankoradia Ishankoradia Ishankoradia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the flag "include_archived" configurable
2 participants
@fatchat @Ishankoradia