Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/update crates #58

Merged
merged 2 commits into from
Feb 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/beider_morse/engine.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ use crate::beider_morse::rule::{Phoneme, PhonemeList, PrivateRuleType, Rule, Rul
use crate::helper::CharSequence;
use crate::NameType;

lazy_static! {
lazy_static::lazy_static! {
static ref NAME_PREFIXES: BTreeMap<NameType, BTreeSet<&'static str>> = BTreeMap::from([
(
NameType::Ashkenazi,
Expand Down Expand Up @@ -261,7 +261,7 @@ impl PhoneticEngine<'_> {
.iter()
.map(|v| {
if self.name_type == NameType::Sephardic {
v.split('\'').last().unwrap()
v.split('\'').next_back().unwrap()
} else {
v
}
Expand Down Expand Up @@ -314,7 +314,7 @@ mod tests {
use crate::beider_morse::DEFAULT_MAX_PHONEMES;
use crate::{ConfigFiles, PhoneticError, RuleType};

lazy_static! {
lazy_static::lazy_static! {
static ref DATA: [(&'static str, &'static str, NameType, RuleType, bool, usize); 8] = [
(
"Renault",
Expand Down
7 changes: 4 additions & 3 deletions src/beider_morse/lang.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ use std::fmt::{Display, Formatter};
use std::path::Path;

use enum_iterator::all;
use nom::Parser;
use regex::Regex;

use crate::beider_morse::{LanguageSet, Languages};
Expand Down Expand Up @@ -105,19 +106,19 @@ fn parse_lang(
// or multiline.

// Try single line comment
if let Ok((rm, _)) = end_of_line()(remains) {
if let Ok((rm, _)) = end_of_line().parse(remains) {
remains = rm;
continue;
}

// Try multiline comment
if let Ok((rm, ln)) = multiline_comment()(remains) {
if let Ok((rm, ln)) = multiline_comment().parse(remains) {
line_number += ln - 1;
remains = rm;
continue;
}

if let Ok((rm, (pattern, langs, accept_on_match))) = lang()(remains) {
if let Ok((rm, (pattern, langs, accept_on_match))) = lang().parse(remains) {
remains = rm;

let pattern: Regex = Regex::new(pattern).map_err(|error| {
Expand Down
7 changes: 4 additions & 3 deletions src/beider_morse/languages.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ use std::collections::{BTreeMap, BTreeSet};
use std::fmt::{Display, Formatter};
use std::path::PathBuf;

use nom::Parser;
use serde::{Deserialize, Serialize};

use crate::beider_morse::NameType;
Expand Down Expand Up @@ -172,20 +173,20 @@ fn parse_liste(list: String) -> Result<BTreeSet<String>, PhoneticError> {
// or multiline.

// Try single line comment
if let Ok((rm, _)) = end_of_line()(remains) {
if let Ok((rm, _)) = end_of_line().parse(remains) {
remains = rm;
continue;
}

// Try multiline comment
if let Ok((rm, ln)) = multiline_comment()(remains) {
if let Ok((rm, ln)) = multiline_comment().parse(remains) {
line_number += ln - 1;
remains = rm;
continue;
}

// Try language
if let Ok((rm, language)) = language()(remains) {
if let Ok((rm, language)) = language().parse(remains) {
remains = rm;
result.insert(language.to_string());
continue;
Expand Down
2 changes: 1 addition & 1 deletion src/beider_morse/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ mod tests {
#[cfg(feature = "embedded_bm")]
use crate::beider_morse::rule::PrivateRuleType;

lazy_static! {
lazy_static::lazy_static! {
static ref CONFIG_FILE: ConfigFiles =
ConfigFiles::new(&PathBuf::from("./test_assets/cc-rules/")).unwrap();
}
Expand Down
9 changes: 5 additions & 4 deletions src/beider_morse/rule.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ use std::str::FromStr;

use either::Either;
use enum_iterator::{all, Sequence};
use nom::Parser;
use regex::Regex;
use serde::{Deserialize, Serialize};

Expand Down Expand Up @@ -225,7 +226,7 @@ fn parse_rule(
// Parrsing test from more probable to less probable.
// Try quadruplet rule
if let Ok((rm, (pattern, left_context, right_context, phoneme_expr))) =
quadruplet()(remains)
quadruplet().parse(remains)
{
remains = rm;
let pattern_length_char = pattern.chars().count();
Expand Down Expand Up @@ -259,13 +260,13 @@ fn parse_rule(
}

// Try single line comment
if let Ok((rm, _)) = end_of_line()(remains) {
if let Ok((rm, _)) = end_of_line().parse(remains) {
remains = rm;
continue;
}

// Try includes file
if let Ok((rm, include_filename)) = include()(remains) {
if let Ok((rm, include_filename)) = include().parse(remains) {
remains = rm;
let rules = parse_rule(resolver, include_filename).map_err(|error| {
if let PhoneticError::BMError(error) = error.clone() {
Expand All @@ -284,7 +285,7 @@ fn parse_rule(
}

// Try multiline comment
if let Ok((rm, ln)) = multiline_comment()(remains) {
if let Ok((rm, ln)) = multiline_comment().parse(remains) {
line_number += ln - 1;
remains = rm;
continue;
Expand Down
10 changes: 6 additions & 4 deletions src/daitch_mokotoff.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
*/
use std::collections::BTreeMap;

use nom::Parser;

use crate::helper::is_vowel;
use crate::{
build_error, end_of_line, folding, multiline_comment, quadruplet, Encoder, PhoneticError,
Expand Down Expand Up @@ -473,7 +475,7 @@ impl<'a> DaitchMokotoffSoundexBuilder<'a> {
// Parrsing test from more probable to less probable.

// Try quadruplet rule
if let Ok((rm, quadruplet)) = quadruplet()(remains) {
if let Ok((rm, quadruplet)) = quadruplet().parse(remains) {
let rule = Rule::try_from(quadruplet)?;
// There's always at least one char, the regex ensures that.
let ch = rule.pattern.chars().next().unwrap();
Expand All @@ -483,20 +485,20 @@ impl<'a> DaitchMokotoffSoundexBuilder<'a> {
}

// Try folding rule
if let Ok((rm, (pattern, replacement))) = folding()(remains) {
if let Ok((rm, (pattern, replacement))) = folding().parse(remains) {
ascii_folding_rules.insert(pattern, replacement);
remains = rm;
continue;
}

// Try single line comment
if let Ok((rm, _)) = end_of_line()(remains) {
if let Ok((rm, _)) = end_of_line().parse(remains) {
remains = rm;
continue;
}

// Try multiline comment
if let Ok((rm, ln)) = multiline_comment()(remains) {
if let Ok((rm, ln)) = multiline_comment().parse(remains) {
line_number += ln;
remains = rm;
continue;
Expand Down
4 changes: 2 additions & 2 deletions src/double_metaphone.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1050,7 +1050,7 @@ mod tests {
*
* Massaged the test data in the array below.
*/
const FIXTURE: [(&str, &str); 547] = [
static FIXTURE: [(&str, &str); 547] = [
("Accosinly", "Occasionally"),
("Ciculer", "Circler"),
("Circue", "Circle"),
Expand Down Expand Up @@ -2228,7 +2228,7 @@ mod tests {
);
}

const TEST_DATA: [(&str, &str, &str); 1221] = [
static TEST_DATA: [(&str, &str, &str); 1221] = [
("ALLERTON", "ALRT", "ALRT"),
("Acton", "AKTN", "AKTN"),
("Adams", "ATMS", "ATMS"),
Expand Down
3 changes: 0 additions & 3 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,6 @@
unused_qualifications
)]
#![cfg_attr(docsrs, feature(doc_auto_cfg))]
#[macro_use]
extern crate lazy_static;

use std::error::Error;
use std::fmt;
use std::fmt::{Display, Formatter};
Expand Down
Loading
Loading