fix: handle lead/lag extreme offset overflow cases (#22221, #22231)#375
Open
Dandandan wants to merge 2 commits into
Open
fix: handle lead/lag extreme offset overflow cases (#22221, #22231)#375Dandandan wants to merge 2 commits into
Dandandan wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
lead/lagare used with extreme offsets such asi64::MINandi64::MAXby handling those edge cases explicitly.lead/lagevaluation returns the configured default value or a descriptive error instead of crashing during planning or execution.Description
WindowShiftKind::shift_offsetto returnResult<i64>and usechecked_negforleadto detect and rejecti64::MINwith aDataFusionError::Executionerror.partition_evaluatorto propagate the newResultfromshift_offsetand keep the reversal logic intact when needed.WindowShiftEvaluator::evaluatewithchecked_suband safeusizeconversion so extreme offsets do not overflow and out-of-range indices map to the default value.test_lead_i64_min_offset_returns_errorandtest_lead_i64_max_offset_evaluate_returns_defaultto cover both issue cases.Testing
cargo fmt --allwhich completed successfully.cargo clippy --all-targets --all-features -- -D warnings, which reported a pre-existing unrelated compilation error indatafusion/physical-plan/benches/aggregate_vectorized.rsand therefore did not fully complete in this environment.datafusion/functions-windowfor the regressions; full test execution in CI is recommended to validate across the repository's build matrix.Codex Task