Reduce duplication when computing nulls#17
Open
alamb wants to merge 1 commit into
Open
Conversation
alamb
commented
Jan 19, 2026
| .slice(offset, len); | ||
| let s = s.as_primitive::<T>(); | ||
|
|
||
| let nulls = s.nulls().filter(|n| n.null_count() > 0); |
Author
There was a problem hiding this comment.
By calculating this one rather than replicating it in each branch, it reduces code and ensures it is consistent (actually the last branch did not filter on null_count)
| // Copy all values | ||
| self.current.extend_from_slice(values); | ||
| if let Some(nulls) = s.nulls() { | ||
| if let Some(nulls) = nulls { |
Author
There was a problem hiding this comment.
this was not consistent with the other branches (it didn't previously check for null count)
However II am pretty sure this code is unreachable 🤷
| ) -> Result<(), ArrowError> { | ||
| // We only support primitve now, fallback to filter_record_batch for other types | ||
| // Also, skip optimization when filter is not very selectivex§ | ||
| // We only support primitive now, fallback to filter_record_batch for other types |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This targets this PR from @Dandandan
push_batch_with_filterup to 3x faster apache/arrow-rs#8951I noticed that there was some duplicated code, and actually one path was not consistent
let's calculate the nulls to use once