Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DUOS-2703][risk=no] Delete study API #2187

Merged
merged 9 commits into from
Dec 5, 2023
Merged

[DUOS-2703][risk=no] Delete study API #2187

merged 9 commits into from
Dec 5, 2023

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Nov 9, 2023 •
edited
Loading

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2703

Summary

  • Refactor study related endpoints to new StudyResource
  • New admin/chair/data submitter API to delete a study
  • Admins can delete anything
  • Chairs/data submitters need to be the create user to delete a study

Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong marked this pull request as ready for review November 27, 2023 20:16
@rushtong rushtong requested a review from a team as a code owner November 27, 2023 20:17
hams7504
hams7504 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@hams7504 hams7504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested 👍

fboulnois
fboulnois approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@rushtong rushtong merged commit e001f48 into develop Dec 5, 2023
11 checks passed
@rushtong rushtong deleted the gr-DUOS-2703-delete-study branch December 5, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fboulnois fboulnois fboulnois approved these changes

@hams7504 hams7504 hams7504 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rushtong @fboulnois @hams7504