Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-1740][risk=no] Revert http client version update #2201

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Nov 28, 2023

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-1740

Summary

Reverts http5 library update which introduced java.lang.IllegalArgumentException: Invalid Proxy errors in status checks.

Will look at an update with potential code fixes separately.


Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong requested a review from a team as a code owner November 28, 2023 15:13
Copy link
Contributor

@hams7504 hams7504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rushtong rushtong merged commit 6b43756 into develop Nov 28, 2023
11 checks passed
@rushtong rushtong deleted the gr-revert-httpclient-upgrade branch November 28, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants