Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DUOS-2830][risk=no] Update DAR Data Use translations for V3 #2205

Merged
merged 6 commits into from
Dec 8, 2023
Merged

[DUOS-2830][risk=no] Update DAR Data Use translations for V3 #2205

merged 6 commits into from
Dec 8, 2023

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Dec 6, 2023 •
edited
Loading

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2830

Summary

Relatively signficant updates to generating the DataUse object for a Data Access Request

  • Deprecate DataUse fields that are no longer in the v3 data use schema
  • Removed an old constructor that was only used for tests along with tests
  • In general, if a field is false, do not populate a data use field
    • The only exception to that is the non-profit case where we need to ensure that both nonProfitUse and commercialUse fields are correctly set.

OLD

Screenshot 2023-12-05 at 12 04 41 PM

NEW

Screenshot 2023-12-06 at 10 14 15 AM

Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong marked this pull request as ready for review December 6, 2023 15:15
@rushtong rushtong requested a review from a team as a code owner December 6, 2023 15:15
fboulnois
fboulnois approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, one suggestion:

src/main/java/org/broadinstitute/consent/http/service/UseRestrictionConverter.java Outdated Show resolved Hide resolved
@rushtong @fboulnois
Update src/main/java/org/broadinstitute/consent/http/service/UseRestr…
3496610 
…ictionConverter.java


PR feedback

Co-authored-by: fboulnois <[email protected]>
hams7504
hams7504 approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@hams7504 hams7504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@rushtong rushtong merged commit b2489f2 into develop Dec 8, 2023
11 checks passed
@rushtong rushtong deleted the gr-DUOS-2830-fix-dar-data-use branch December 8, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fboulnois fboulnois fboulnois approved these changes

@hams7504 hams7504 hams7504 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rushtong @fboulnois @hams7504