Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DUOS-2781] DAC rejects datasets #2216

Merged
merged 2 commits into from
Dec 20, 2023
Merged

[DUOS-2781] DAC rejects datasets #2216

merged 2 commits into from
Dec 20, 2023

Conversation

hams7504
Copy link
Contributor

@hams7504 hams7504 commented Dec 15, 2023 •
edited
Loading

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2781

Summary

  • Changed email content for the case where a DAC rejects a dataset

Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@hams7504 hams7504 marked this pull request as ready for review December 18, 2023 14:32
@hams7504 hams7504 requested a review from a team as a code owner December 18, 2023 14:32
@hams7504 hams7504 changed the title change email contents + add dac email [DUOS-2781] DAC rejects datasets Dec 18, 2023
rushtong
rushtong reviewed Dec 18, 2023
View reviewed changes
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one suggestion inline

rushtong
rushtong approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes 👍🏽

@hams7504 hams7504 merged commit b4580e3 into hm-duos-2782-dac-accepts-datasets Dec 20, 2023
4 checks passed
@hams7504 hams7504 deleted the hm-duos-2781-dac-denies-datasets branch December 20, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rushtong rushtong rushtong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hams7504 @rushtong