Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-2887][risk=no] New api to search for dataset summaries #2234

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Jan 19, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2887

Summary

  • New api to search for DAC-approved dataset summary objects based on a query term
  • GET /api/dataset/autocomplete?query=
  • Similar to the current /api/dataset/search endpoint but much more limited in search scope, faster, and has a smaller payload

Returns a list of summary objects:

[
  {
    "id": 1415,
    "identifier": "DUOS-000617",
    "name": "Test-05-01-23"
  },
  {
    "id": 1417,
    "identifier": "DUOS-000618",
    "name": "2-Test-05-01-23"
  }, ...
]

Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

Copy link

@nmalfroy nmalfroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome! Thanks for doing this so quickly! I'll update the TDR UI as soon as this is live

@rushtong rushtong marked this pull request as ready for review January 19, 2024 19:04
@rushtong rushtong requested a review from a team as a code owner January 19, 2024 19:04
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

Copy link
Contributor

@aarohinadkarni aarohinadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rushtong rushtong merged commit 43017c5 into develop Jan 22, 2024
11 checks passed
@rushtong rushtong deleted the gr-autocomplete-datasets branch January 22, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants