[DUOS-2780] System Email - DAR submitted to DAC Chair #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hams7504
changed the title
hams7504
force-pushed
the
hm-duos-2780-dar-submitted-to-chair
branch
from
2684d39 to
42ca0a8
Compare
hams7504
changed the title
rushtong
reviewed
Feb 26, 2024
| @@ -128,6 +150,26 @@ public List<MailMessage> fetchEmailMessagesByCreateDate(Date start, Date end, In | |||
| public void sendNewDARCollectionMessage(Integer collectionId) | |||
| throws IOException, TemplateException { | |||
| DarCollection collection = collectionDAO.findDARCollectionByCollectionId(collectionId); | |||
| List<User> distinctUsers = getDistinctUsers(collection); | |||
| DataAccessRequest dar = dataAccessRequestDAO.findByReferenceId(collection.getDarCode()); | |||
There was a problem hiding this comment.
We need to fix this, the dar code is not the same as the reference id.
Comment on lines
224
to
231
| @SqlQuery(""" | ||
| select dac.* | ||
| from dac | ||
| inner join dataset d on d.dac_id = dac.dac_id | ||
| inner join dar_dataset dd on dd.dataset_id = d.dataset_id | ||
| inner join data_access_request dar on dd.reference_id = dar.reference_id | ||
| where dar.collection_id = :collectionId | ||
| """) |
There was a problem hiding this comment.
We should standardize the casing here
Comment on lines
155
to
157
| String researcherName = userDAO.findUserById(dar.getUserId()).getDisplayName(); | ||
| Collection<Dac> dacsInDAR = dacDAO.findDacsForCollectionId(collectionId); | ||
| List<Dataset> datasetsInDAR = datasetDAO.findDatasetsByIdList(dar.datasetIds); |
There was a problem hiding this comment.
We need some safety checking around the bulk calls to ensure we're not passing empty lists.
Shakespeared
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DUOS-2780
Summary
Have you read CONTRIBUTING.md lately? If not, do that first.