Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-2884][risk=no] Bug Fix: Ensure users exist for sending submitted dataset emails #2243

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Feb 5, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2884

Summary

  • Minor bug fix to get chairs for each DAC when sending submitted dataset emails.

Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong requested a review from a team as a code owner February 5, 2024 19:17
Copy link
Contributor

@aarohinadkarni aarohinadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. I wonder if we can add a test for this issue?

feat: test for different chair conditions
@rushtong rushtong merged commit f67f04f into develop Feb 6, 2024
11 checks passed
@rushtong rushtong deleted the gr-DUOS-2884-get-chairpersons branch February 6, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants