Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DT-1122] Apply zizmor suggestions #2445

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

fboulnois
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DT-1122

Summary

  • The Github actor is already logged on the action run page
  • Do not persist credentials if not needed
  • Use shell variable expansion instead of template expansion

Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@fboulnois fboulnois requested a review from a team as a code owner January 8, 2025 18:08
@fboulnois fboulnois requested review from rushtong and s-rubenstein and removed request for a team January 8, 2025 18:08
@fboulnois fboulnois force-pushed the fb-dt-1122-apply-zizmor-fixes branch 3 times, most recently from 32b4935 to b1c203e Compare January 8, 2025 18:22
@fboulnois fboulnois force-pushed the fb-dt-1122-apply-zizmor-fixes branch from b1c203e to c0960ab Compare January 8, 2025 18:27
-t ${{ steps.construct-tags.outputs.environment-tag }} \
.
- name: Log Github Actor
run: echo "${{ github.actor }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't we need this Log Github Actor part anymore?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actors are logged in the action runs so it isn't necessary to write this to the logs.

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@fboulnois fboulnois merged commit ac80e10 into develop Jan 10, 2025
14 checks passed
@fboulnois fboulnois deleted the fb-dt-1122-apply-zizmor-fixes branch January 10, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants