Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics - End date for get_change_over_time_df should be inclusive #4365

Closed
jpaten opened this issue Feb 5, 2025 · 0 comments · Fixed by #4366
Closed

Analytics - End date for get_change_over_time_df should be inclusive #4365

jpaten opened this issue Feb 5, 2025 · 0 comments · Fixed by #4366
Assignees
Labels
canary Done by the Clever Canary team

Comments

@jpaten
Copy link
Contributor

jpaten commented Feb 5, 2025

  • Currently the end date for get_change_over_time_df is excluded from the date range, so if the time dimension is yearMonth the end date must be after the last month to be included in the report. This is inconsistent with get_flat_data_df, where the last day is included in the report, making the functions in sheets_element more confusing than necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canary Done by the Clever Canary team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant