Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get_change_df_over_time uses an inclusive range (#4365) #4366

Merged
merged 1 commit into from
Feb 6, 2025
Merged

fix: get_change_df_over_time uses an inclusive range (#4365) #4366

merged 1 commit into from
Feb 6, 2025

Conversation

jpaten
Copy link
Contributor

@jpaten jpaten commented Feb 5, 2025

Ticket

Closes #4365.

Reviewers

@hunterckx.

Changes

  • Made the date range for get_change_df_over_time_df inclusive rather than half-open, to make it consistent with get_flat_data_df

@jpaten jpaten requested a review from hunterckx February 5, 2025 23:52
@jpaten jpaten linked an issue Feb 5, 2025 that may be closed by this pull request
Analytics - End date for get_change_over_time_df should be inclusive #4365
Closed
@github-actions github-actions bot added the canary Done by the Clever Canary team label Feb 5, 2025
This was referenced Feb 5, 2025
Merged
Merged
hunterckx
hunterckx approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@hunterckx hunterckx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jpaten!

@hunterckx hunterckx merged commit e2653f5 into main Feb 6, 2025
3 of 4 checks passed
@NoopDog NoopDog mentioned this pull request Feb 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hunterckx hunterckx hunterckx approved these changes

Assignees

@hunterckx hunterckx

Labels
canary Done by the Clever Canary team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Analytics - End date for get_change_over_time_df should be inclusive
2 participants
@jpaten @hunterckx