Skip to content

Run anvil cmg playwright in pull requests (#3637)#3666

Merged
hunterckx merged 18 commits intomainfrom
jonah/3637-run-anvil-cmg-playwright-in-pr
Apr 13, 2024
Merged

Run anvil cmg playwright in pull requests (#3637)#3666
hunterckx merged 18 commits intomainfrom
jonah/3637-run-anvil-cmg-playwright-in-pr

Conversation

@mrtopsyt
Copy link
Contributor

Ticket

Closes #3637 .

Reviewers

@NoopDog .

Changes

  • Changed AnVIL-CMG tests to run on all platforms and fixed errors that only appeared on certain platforms
  • Added Github Action to run Anvil-CMG tests automatically

Tests can be run locally with npm run test:anvil-cmg, and will run much faster locally than on Github. Tests are described in this document

@mrtopsyt mrtopsyt force-pushed the jonah/3637-run-anvil-cmg-playwright-in-pr branch 4 times, most recently from 9077e72 to 749025b Compare September 22, 2023 23:20
@mrtopsyt mrtopsyt requested a review from NoopDog September 23, 2023 00:52
@mrtopsyt mrtopsyt force-pushed the jonah/3637-run-anvil-cmg-playwright-in-pr branch from ae08ab9 to 5359bd9 Compare April 10, 2024 21:27
@mrtopsyt mrtopsyt force-pushed the jonah/3637-run-anvil-cmg-playwright-in-pr branch from 55974cd to 1598e76 Compare April 10, 2024 22:03
@mrtopsyt mrtopsyt requested review from hunterckx and removed request for NoopDog April 10, 2024 23:41
}

export async function testSort(page: Page, tab: TabDescription): Promise<void> {
export async function testSortAzure(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure should be replaced with Azul, and then I think this will be good to go!

Copy link
Contributor

@hunterckx hunterckx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hunterckx hunterckx merged commit 510d9a5 into main Apr 13, 2024
@mrtopsyt mrtopsyt deleted the jonah/3637-run-anvil-cmg-playwright-in-pr branch April 13, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run E2E smoke test for AnVIL CMG dev in a GitHub Action on PR

2 participants

Comments