Create FedRAMP 3PAO pen test deployment (Databiospere/azul#6246) #4048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frano-m
approved these changes
May 24, 2024
There was a problem hiding this comment.
LGTM thanks @hannes-ucsc 🌟.
As a side-note - I wondered whether you intentionally want the browserUrl value passed in to makeConfig to be different to `NEXT_PUBLIC_SITEMAP_DOMAIN'? I haven't reviewed the gitlab files but the config looks great. Thanks.
hannes-ucsc
force-pushed
the
issues/hannes-ucsc/6246-temp
branch
2 times, most recently
from
8f7a9b4 to
3c08275
Compare
Good catch. Fixed. |
|
Can I merge this? |
|
Yes, this is approved. Rebase and merge! |
hannes-ucsc
force-pushed
the
issues/hannes-ucsc/6246-temp
branch
from
3c08275 to
513bd16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.