Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: cleanup playwright tests (#4078) #4079

Merged
merged 15 commits into from
Sep 13, 2024
Merged

test: cleanup playwright tests (#4078) #4079

merged 15 commits into from
Sep 13, 2024

Conversation

mrtopsyt
Copy link
Contributor

@mrtopsyt mrtopsyt commented Jul 22, 2024 •
edited
Loading

Ticket

Closes #4078

  • Resolved a typo that led test descriptions to be incorrect for AnVIL-Catalog tab tests
  • Refactored and added comments to testFunctions.ts
  • Made the Pagination last page test use a filter to decrease runtime and flakiness
  • Refactored Pagination tests to store content in testFunctions.ts and to remove anvil-pagination.spec.ts
  • Refactored tab column names to be stored as objects indexed by their name instead of being arrays, and switched tab names to be stored as constants instead of being repeated in each ColumnDescription
  • Redesigned sort and tab name tests to not depend on tab order
  • Made all tests that have early exit conditions return a boolean value instead of calling test.fail(), which led to the incorrect result
  • Added tsdocs where they were missing in testFunctions.ts

@mrtopsyt mrtopsyt linked an issue Jul 22, 2024 that may be closed by this pull request
Cleanup Playwright Tests #4078
Closed
@github-actions github-actions bot added the canary Done by the Clever Canary team label Jul 22, 2024
@mrtopsyt mrtopsyt changed the title Jonah/4078 cleanup playwright tests test: cleanup playwright tests Aug 23, 2024
@mrtopsyt mrtopsyt changed the title test: cleanup playwright tests test: cleanup playwright tests (#4078) Aug 23, 2024
@mrtopsyt mrtopsyt force-pushed the jonah/4078-cleanup-playwright-tests branch from b8b976c to 48e0539 Compare August 24, 2024 02:13
@mrtopsyt mrtopsyt marked this pull request as draft September 10, 2024 23:47
@mrtopsyt mrtopsyt force-pushed the jonah/4078-cleanup-playwright-tests branch from 0a2d95a to 92f39d2 Compare September 11, 2024 00:00
MillenniumFalconMechanic
MillenniumFalconMechanic approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@MillenniumFalconMechanic MillenniumFalconMechanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Jonah!

@mrtopsyt mrtopsyt marked this pull request as ready for review September 11, 2024 23:54
@mrtopsyt mrtopsyt force-pushed the jonah/4078-cleanup-playwright-tests branch from 3ee525f to 2a73b78 Compare September 12, 2024 21:21
MillenniumFalconMechanic
MillenniumFalconMechanic approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@MillenniumFalconMechanic MillenniumFalconMechanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Jonah!

mrtopsyt and others added 15 commits September 12, 2024 15:20
@mrtopsyt
fix: refactored tests (#4068)
3ad0b5d
@mrtopsyt
fix: refactored tests (#4068)
e01b338
@mrtopsyt
fix: refactored locators and cleaned up typos in tests (#4078)
6306a46
@mrtopsyt
test: added tests for anvil-cmg datasets backpages (#4080)
b5cafaf
@mrtopsyt
test: fixed changes that broke with rebasing and made export tests sk…
3c19da4 
…ip (#4080)
@mrtopsyt
fix: refactored tests (#4068)
0b4ffcd
@mrtopsyt
fix: refactored locators and cleaned up typos in tests (#4078)
652380c
@mrtopsyt
fix: removed redundant file-level configuration, increased anvil-cata…
43de19a 
…log timeout to 60s (#4078)
@mrtopsyt
test: corrected errors in complex rebase (#4078)
545987d
@mrtopsyt
test: cleaned up pagination tests (#4078)
68f50e9
@mrtopsyt
test: switched to MACRO_CASE for test constants (#4078)
62f6d5b
test: fixed issues from rebase (#4078)
a57a1d4
test: made tests not dependent on tab order and refactored constants …
363750d 
…to constants.ts (#4078)
test: removed redundant TODO (#4078)
9f18017
test: attempt to fix flakiness with filter counts (#4078)
67f5dd4
@mrtopsyt mrtopsyt force-pushed the jonah/4078-cleanup-playwright-tests branch from 2a73b78 to 67f5dd4 Compare September 12, 2024 22:55
@mrtopsyt mrtopsyt merged commit 55108ab into main Sep 13, 2024
4 checks passed
@mrtopsyt mrtopsyt deleted the jonah/4078-cleanup-playwright-tests branch September 13, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MillenniumFalconMechanic MillenniumFalconMechanic MillenniumFalconMechanic approved these changes

Assignees
No one assigned
Labels
canary Done by the Clever Canary team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup Playwright Tests
2 participants
@mrtopsyt @MillenniumFalconMechanic