Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added system status check to anvil-cmg tests (#4108) #4115

Merged
merged 4 commits into from
Aug 18, 2024
Merged

chore: added system status check to anvil-cmg tests (#4108) #4115

merged 4 commits into from
Aug 18, 2024

Conversation

jpaten
Copy link
Contributor

@jpaten jpaten commented Aug 16, 2024 •
edited
Loading

Ticket

Closes #4108 .

Reviewers

@NoopDog .

Changes

  • Added a script to check the indexing status
  • Added this script to the anvil-cmg tests

Known Issues

  • This check relies on the Azul /health/progress api, which according to the documentation "should not be requested frequently or by automated monitoring facilities that would be better served by the /health/fast or /health/cached endpoints." However, this api is already used to generate the indexing status alert, so I assume this isn't an issue?

@jpaten jpaten linked an issue Aug 16, 2024 that may be closed by this pull request
Add script to AnVIL-CMG test action to auto-fail tests if the site is indexing #4108
Closed
@github-actions github-actions bot added the canary Done by the Clever Canary team label Aug 16, 2024
@jpaten jpaten marked this pull request as ready for review August 16, 2024 22:52
@NoopDog NoopDog requested a review from hunterckx August 16, 2024 23:14
hunterckx
hunterckx approved these changes Aug 18, 2024
View reviewed changes
Copy link
Contributor

@hunterckx hunterckx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hunterckx hunterckx merged commit e37768b into main Aug 18, 2024
4 checks passed
@jpaten jpaten deleted the 4108-add-script-to-anvil-cmg-test-action-to-auto-fail-tests-if-the-site-is-indexing branch August 19, 2024 16:48
jpaten added a commit that referenced this pull request Aug 19, 2024
@jpaten
chore: added system status check to anvil-cmg tests (#4108) (#4115)
2aca06a 
* chore: added system status check to anvil-cmg tests (#4108)

* chore: added second system status check after tests run to ensure reliability (#4108)

* chore: check that indexing checks fail appropriately (#4108)

* chore: undo test failure check (#4108)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hunterckx hunterckx hunterckx approved these changes

Assignees
No one assigned
Labels
canary Done by the Clever Canary team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add script to AnVIL-CMG test action to auto-fail tests if the site is indexing
2 participants
@jpaten @hunterckx