Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-2869] Fix various errors in dev #2431

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Conversation

fboulnois
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2869

Summary

Fix various errors in dev


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@fboulnois fboulnois requested a review from a team as a code owner January 9, 2024 17:53
@fboulnois fboulnois changed the title Fix various errors in dev [DUOS-2869] Fix various errors in dev Jan 9, 2024
@fboulnois fboulnois marked this pull request as draft January 9, 2024 19:39
@fboulnois fboulnois marked this pull request as ready for review January 9, 2024 21:35
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@fboulnois fboulnois merged commit c2a0bb8 into develop Jan 11, 2024
9 checks passed
@fboulnois fboulnois deleted the fb-fix-various-dev-errors branch January 11, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants