Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-2860] Remove duplicate display of profile and lc warning in DAR form #2444

Conversation

aarohinadkarni
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2860

Summary

Removes duplicate profile & library card warning & changes styling for warning that is kept to alert users from the start if those requirements aren't met.

Screenshot 2024-01-22 at 4 16 23 PM

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@aarohinadkarni aarohinadkarni requested a review from a team as a code owner January 22, 2024 21:17
@aarohinadkarni aarohinadkarni changed the title An duos 2860 duplicate display of profile and lc warning in dar form [DUOS-2860] Remove duplicate display of profile and lc warning in DAR form Jan 22, 2024
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@aarohinadkarni aarohinadkarni merged commit cbb44be into develop Jan 31, 2024
9 checks passed
@aarohinadkarni aarohinadkarni deleted the an-DUOS-2860-duplicate-display-of-profile-and-lc-warning-in-DAR-form branch January 31, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants