[DT-1250][risk=no] Check for lint in the files that have changed between this PR and the destination branch. #2791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ches referenced for the diff.
otchet-broad
commented
Feb 18, 2025
| - uses: actions/checkout@v4 | ||
| with: | ||
| persist-credentials: false | ||
| fetch-depth: 0 |
There was a problem hiding this comment.
Required to get the develop branch.
otchet-broad
commented
Feb 18, 2025
otchet-broad
requested review from
snf2ye,
s-rubenstein,
rushtong and
fboulnois
and removed request for
a team
rushtong
reviewed
Feb 18, 2025
fboulnois
reviewed
Feb 18, 2025
Use an environment variable instead of directly referencing the template. Co-authored-by: fboulnois <[email protected]>
|
I see why the failure is happening, I would switch it to |
rushtong
reviewed
Feb 19, 2025
| with: | ||
| persist-credentials: false | ||
| fetch-depth: 0 | ||
| - run: echo "NODE_VERSION=$(cat Dockerfile | awk 'NR==2 {gsub(":","@",$2); print $2}' | awk '{split($0, array, "@"); print array[2]}')" >> $GITHUB_ENV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DT-1250
Summary
Lint checking on only files that have changed in this PR.
Screenshots
When there's no lint, the action passes as expected. The file in this case is excluded because of linter configuration.
When there's lint, we get a failure:
When the lint is fixed:
Lint history tracked in PR history:
Have you read Terra's Contributing Guide lately? If not, do that first.