WOR-1120 Add smoke tests to landing zone service #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiygetlin
changed the title
sergiygetlin
requested review from
a team,
blakery and
marctalbott
and removed request for
a team and
blakery
marctalbott
approved these changes
Dec 18, 2023
aherbst-broad
approved these changes
Dec 19, 2023
| def status_url() -> str: | ||
| return SmokeTestCase.build_lz_url("/api/landingzones/definitions/v1/azure") | ||
|
|
||
| """Validates that definitions endpoint return 401 when no token provided""" |
There was a problem hiding this comment.
The placement of this docstring should be inside the method like so https://peps.python.org/pep-0257/#one-line-docstrings, curious if black will pick this up.
blakery
approved these changes
Dec 19, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smoke tests for landing zone:
-validates /status endpoint
-validates /version endpoint
-validates landing zone definitions endpoint
-validates endpoint which list all available landing zones to user