Enable TNU to use Azure auth for DRS operations #399 #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaumann-broad
force-pushed
the
mbaumann-issue-399-add-drs-azure-auth
branch
from
963a76c to
621e3b6
Compare
rtitle
reviewed
Jan 17, 2023
rtitle
reviewed
Jan 17, 2023
There was a problem hiding this comment.
Overall looks good. I like the tagging of execution_platform and execution_context.
Were you able to test in a real Azure workspace notebook against an Azure DRS URL? It looks like there is still some GCP-specific logic in drs.py (such as checking requester-pays, and trying to resolve the file a GCS object if the signed url doesn't work). But hopefully the auth piece is enough to simply make it work for Azure signed URLs.
nmalfroy
reviewed
Jan 17, 2023
added 4 commits
January 19, 2023 05:02
Add support for using Microsoft Azure default credentials when running in a Terra Azure Interactive Analysis Cloud Environment. These credentials are used to auth with Terra backend services, including Martha/terra-drs-hub and Rawls. When running in a Terra Google IA Cloud Environment, the behavior is as before, with no changes. This initial implementation is thought to be functionally complete, yet tests and documentation remain to be added.
Currently, there is not enough reliable information available to accurately determine the execution environment and execution platform. Until that is available, change get_execution_context to provide better values for the most common cases.
mbaumann-broad
force-pushed
the
mbaumann-issue-399-add-drs-azure-auth
branch
from
11756a3 to
37e4018
Compare
mbaumann-broad
changed the title
DailyDreaming
approved these changes
Jan 24, 2023
nmalfroy
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a description of the change, see: #399
Status