Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CE_UMH_CORE_PATTERN edge #209

Merged
merged 28 commits into from
Sep 13, 2024
Merged

Add CE_UMH_CORE_PATTERN edge #209

merged 28 commits into from
Sep 13, 2024

Conversation

martinvoigt-dd
Copy link
Contributor

This PR adds the edge calculation for the CE_UMH_CORE_PATTERN technique.

core_pattern_edge_screenshot

@martinvoigt-dd martinvoigt-dd requested a review from a team as a code owner June 20, 2024 13:03
jt-dd
jt-dd reviewed Sep 11, 2024
View reviewed changes
Copy link
Contributor

@jt-dd jt-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding the attack. Since there have been some changes, can you take care of the comments and then I will do the merge into main.

I find it weird it does not need to modify more system-tests.

docs/reference/attacks/CE_UMH_CORE_PATTERN.md Outdated Show resolved Hide resolved
docs/reference/attacks/CE_UMH_CORE_PATTERN.md Outdated Show resolved Hide resolved
docs/reference/attacks/CE_UMH_CORE_PATTERN.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@jt-dd jt-dd self-requested a review September 13, 2024 08:26
@jt-dd jt-dd merged commit c532f89 into DataDog:main Sep 13, 2024
4 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jt-dd jt-dd jt-dd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinvoigt-dd @jt-dd