Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(doc) More precise installation instructions #327

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

Minosity-VR
Copy link
Contributor

@Minosity-VR Minosity-VR commented Feb 5, 2025

Motivation

Address #326 : building the image from source should not be done straight from main as changes on main are not "pushed" to the registries until a new tag is created, but instead it should be done at a specific tagged commit

Changes

  • Add checkout instructions in dev-guide
  • Add checkout instructions in README
  • Add homebrew instructions in README
  • In the docker tag selector function, prevent overriding the build tag with "latest" if we are on a detached commit (which is the case when building from a release tag)

@Minosity-VR Minosity-VR requested a review from a team as a code owner February 5, 2025 15:40
@Minosity-VR Minosity-VR merged commit fcc3ecc into main Feb 5, 2025
9 checks passed
@Minosity-VR Minosity-VR deleted the simon.marechal/install-doc branch February 5, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants