Skip to content

Conversation

@Pierre-L42
Copy link
Member

@Pierre-L42 Pierre-L42 commented Nov 27, 2025

What does this PR do?

https://datadoghq.atlassian.net/browse/AGENT-15023

The support ticket above has a customer that needs to restart their Agent to pick-up a metric.

This is because this PR introduced the logic to delete the OIDs to query that the device do not report, and the OIDs to query were refreshed every 10min again to pick-up new OIDs. However the logic to refresh every 10min only applied for OIDs defined in profiles and not the inline OIDs defined in the instance config (which is the case in the support ticket). This PR aims to fix this by refreshing the profile for whatever way the user defined their OIDs.

Motivation

Describe how you validated your changes

Additional Notes

@github-actions github-actions bot added team/ndm-core short review PR is simple enough to be reviewed quickly labels Nov 27, 2025
@Pierre-L42 Pierre-L42 added the qa/no-code-change No code change in Agent code requiring validation label Nov 27, 2025
@cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 5c26d9ae-b959-4196-bc99-f4bc7edf89de

Baseline: c76536c
Comparison: f287356
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +0.88 [-2.06, +3.82] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.61 [+0.17, +3.06] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +1.50 [+1.42, +1.57] 1 Logs
docker_containers_cpu % cpu utilization +0.88 [-2.06, +3.82] 1 Logs
ddot_metrics memory utilization +0.67 [+0.45, +0.89] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.29 [+0.24, +0.35] 1 Logs
quality_gate_metrics_logs memory utilization +0.21 [+0.00, +0.42] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.20 [-0.04, +0.43] 1 Logs
ddot_metrics_sum_delta memory utilization +0.16 [-0.04, +0.35] 1 Logs
file_tree memory utilization +0.14 [+0.09, +0.20] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.08 [-0.32, +0.47] 1 Logs
otlp_ingest_logs memory utilization +0.03 [-0.07, +0.13] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.03 [-0.34, +0.40] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.01 [-0.12, +0.14] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.00 [-0.05, +0.05] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.09, +0.08] 1 Logs
quality_gate_idle_all_features memory utilization -0.01 [-0.07, +0.04] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api ingress throughput -0.02 [-0.15, +0.11] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.05 [-0.48, +0.37] 1 Logs
ddot_logs memory utilization -0.07 [-0.13, -0.00] 1 Logs
otlp_ingest_metrics memory utilization -0.13 [-0.27, +0.01] 1 Logs
docker_containers_memory memory utilization -0.19 [-0.27, -0.11] 1 Logs
quality_gate_idle memory utilization -0.26 [-0.32, -0.21] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulative memory utilization -0.27 [-0.42, -0.12] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor c76536c

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${+0}$$ $${705.11}$$ < $${717.44}$$ $${-0.06}$$ $${172.78}$$ < $${177.37}$$
agent_deb_amd64_fips $${+0}$$ $${700.11}$$ < $${711.66}$$ $${-0.02}$$ $${171.73}$$ < $${174.84}$$
agent_heroku_amd64 $${+0}$$ $${326.71}$$ < $${337.57}$$ $${+0}$$ $${87.24}$$ < $${90.78}$$
agent_msi $${+0}$$ $${980.94}$$ < $${1015.38}$$ $${+0.03}$$ $${142.03}$$ < $${149.42}$$
agent_rpm_amd64 $${+0}$$ $${705.1}$$ < $${717.41}$$ $${-0}$$ $${175.9}$$ < $${178.01}$$
agent_rpm_amd64_fips $${+0}$$ $${700.1}$$ < $${711.64}$$ $${+0.02}$$ $${173.96}$$ < $${177.26}$$
agent_rpm_arm64 $${+0}$$ $${690.5}$$ < $${702.19}$$ $${-0.02}$$ $${159.71}$$ < $${163.22}$$
agent_rpm_arm64_fips $${+0}$$ $${686.49}$$ < $${697.6}$$ $${-0.01}$$ $${159.1}$$ < $${162.68}$$
agent_suse_amd64 $${+0}$$ $${705.1}$$ < $${717.41}$$ $${-0}$$ $${175.9}$$ < $${178.01}$$
agent_suse_amd64_fips $${+0}$$ $${700.1}$$ < $${711.64}$$ $${+0.02}$$ $${173.96}$$ < $${177.26}$$
agent_suse_arm64 $${+0}$$ $${690.5}$$ < $${702.19}$$ $${-0.02}$$ $${159.71}$$ < $${163.22}$$
agent_suse_arm64_fips $${+0}$$ $${686.49}$$ < $${697.6}$$ $${-0.01}$$ $${159.1}$$ < $${162.68}$$
docker_agent_amd64 $${+0}$$ $${767.45}$$ < $${769.92}$$ $${-0.01}$$ $${260.61}$$ < $${261.52}$$
docker_agent_arm64 $${+0}$$ $${777.18}$$ < $${779.46}$$ $${-0}$$ $${250.82}$$ < $${251.72}$$
docker_agent_jmx_amd64 $${+0}$$ $${958.33}$$ < $${960.8}$$ $${-0.01}$$ $${329.26}$$ < $${330.15}$$
docker_agent_jmx_arm64 $${+0}$$ $${956.78}$$ < $${958.93}$$ $${-0.01}$$ $${315.45}$$ < $${316.35}$$
docker_cluster_agent_amd64 $${+0}$$ $${178.31}$$ < $${207.49}$$ $${+0}$$ $${62.99}$$ < $${70.2}$$
docker_cluster_agent_arm64 $${-0}$$ $${195.83}$$ < $${223.38}$$ $${+0}$$ $${59.73}$$ < $${66.42}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${0}$$ $${38.56}$$ < $${39.3}$$ $${+0}$$ $${14.9}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${0}$$ $${37.24}$$ < $${37.94}$$ $${+0}$$ $${14.35}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.79}$$ < $${30.53}$$ $${+0}$$ $${7.86}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${0}$$ $${28.3}$$ < $${29.11}$$ $${-0}$$ $${6.8}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.79}$$ < $${30.53}$$ $${-0}$$ $${7.87}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${0}$$ $${29.79}$$ < $${30.53}$$ $${-0}$$ $${7.87}$$ < $${8.76}$$
iot_agent_deb_amd64 $${0}$$ $${42.54}$$ < $${43.19}$$ $${+0}$$ $${11.11}$$ < $${11.98}$$
iot_agent_deb_arm64 $${0}$$ $${40.28}$$ < $${40.92}$$ $${+0}$$ $${9.57}$$ < $${10.45}$$
iot_agent_deb_armhf $${0}$$ $${40.19}$$ < $${40.86}$$ $${+0}$$ $${9.68}$$ < $${10.56}$$
iot_agent_rpm_amd64 $${0}$$ $${42.54}$$ < $${43.19}$$ $${-0}$$ $${11.13}$$ < $${12.0}$$
iot_agent_suse_amd64 $${0}$$ $${42.54}$$ < $${43.19}$$ $${-0}$$ $${11.13}$$ < $${12.0}$$

@Pierre-L42 Pierre-L42 changed the title [NDMII-3715] Fix profile not refreshed when using inline metrics [NDMII-3715] Fix profile not refreshed when the profile is an inline profile Nov 27, 2025
@Pierre-L42 Pierre-L42 marked this pull request as ready for review November 27, 2025 16:45
@Pierre-L42 Pierre-L42 requested review from a team as code owners November 27, 2025 16:45
@Pierre-L42 Pierre-L42 requested a review from jedupau November 27, 2025 16:45
@Pierre-L42 Pierre-L42 added this to the 7.75.0 milestone Nov 27, 2025
---
fixes:
- |
Fix a bug in SNMP integration where some metrics defined in an instance config were not reported.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Fix a bug in SNMP integration where some metrics defined in an instance config were not reported.
Fixes a bug in the SNMP integration, where some metrics defined in an instance config were not reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/ndm-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants