[AMCC-160] Tidy metric_filterlist field

[StephenWakely]

What does this PR do?

Tidies up the code a bit from #43454.

Motivation

A better way to utilise configuration layers to handle updating the metric_filterlist field, both from the config (when set via the older statsd_metric_blocklist field) and via RC.

If the field is renamed from statsd_metric_blocklist, this setting will be overriden with an empty list and copied into the metric_filterlist field in the model.SourceAgentRuntime config layer.

Any updates from RC are added to the model.SourceRC layer. If an empty list is received from RC, then the settings are just Unset at this layer, restoring to the previously set values.

Describe how you validated your changes

I have added extra unit tests to ensure it works.

Additional Notes

There is a deadlock fix in Viper here. I believe @hush-hush will be submitting that in a separate PR before this will be merged..

[pgimalac]

🥜 nitpick: ‏if it's only used for tests it might be best to move it to a file with the test build tag, to prevent any use outside of tests

[StephenWakely]

Would there be any advantage to doing that? I can't see anything outside of a test using it, but there wouldn't be a problem if something else did find it useful..

[pgimalac]

I don't have context on how this is used, I just saw the comment Used for tests., so I figured in that case we should statically enforce that it can only be used for tests
Otherwise we might as well remove the comment 😄

[StephenWakely]

Yeah that's fair...

[agent-platform-auto-pr]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor ed88b88

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${-0}$$	$${705.48}$$ < $${717.44}$$	$${+0.02}$$	$${172.99}$$ < $${177.37}$$
✅	agent_deb_amd64_fips	$${0}$$	$${699.53}$$ < $${711.66}$$	$${+0}$$	$${171.63}$$ < $${174.84}$$
✅	agent_heroku_amd64	$${0}$$	$${327.54}$$ < $${337.57}$$	$${+0}$$	$${87.36}$$ < $${90.78}$$
✅	agent_msi	$${-0}$$	$${999.88}$$ < $${1015.38}$$	$${0}$$	$${144.39}$$ < $${149.42}$$
✅	agent_rpm_amd64	$${-0}$$	$${705.47}$$ < $${717.41}$$	$${-0.05}$$	$${175.97}$$ < $${178.01}$$
✅	agent_rpm_amd64_fips	$${0}$$	$${699.52}$$ < $${711.64}$$	$${-0.01}$$	$${173.76}$$ < $${177.26}$$
✅	agent_rpm_arm64	$${0}$$	$${690.7}$$ < $${702.19}$$	$${+0.02}$$	$${159.92}$$ < $${163.22}$$
✅	agent_rpm_arm64_fips	$${0}$$	$${685.88}$$ < $${697.6}$$	$${-0.01}$$	$${158.98}$$ < $${162.68}$$
✅	agent_suse_amd64	$${-0}$$	$${705.47}$$ < $${717.41}$$	$${-0.05}$$	$${175.97}$$ < $${178.01}$$
✅	agent_suse_amd64_fips	$${0}$$	$${699.52}$$ < $${711.64}$$	$${-0.01}$$	$${173.76}$$ < $${177.26}$$
✅	agent_suse_arm64	$${0}$$	$${690.7}$$ < $${702.19}$$	$${+0.02}$$	$${159.92}$$ < $${163.22}$$
✅	agent_suse_arm64_fips	$${0}$$	$${685.88}$$ < $${697.6}$$	$${-0.01}$$	$${158.98}$$ < $${162.68}$$
✅	docker_agent_amd64	$${-0}$$	$${767.9}$$ < $${769.92}$$	$${+0}$$	$${260.9}$$ < $${261.52}$$
✅	docker_agent_arm64	$${+0}$$	$${777.44}$$ < $${779.46}$$	$${+0}$$	$${251.09}$$ < $${251.72}$$
✅	docker_agent_jmx_amd64	$${-0}$$	$${958.78}$$ < $${960.8}$$	$${+0}$$	$${329.53}$$ < $${330.15}$$
✅	docker_agent_jmx_arm64	$${-0}$$	$${957.04}$$ < $${958.93}$$	$${+0}$$	$${315.71}$$ < $${316.35}$$
✅	docker_cluster_agent_amd64	$${0}$$	$${178.24}$$ < $${207.49}$$	$${-0}$$	$${62.97}$$ < $${70.2}$$
✅	docker_cluster_agent_arm64	$${+0}$$	$${195.77}$$ < $${223.38}$$	$${+0}$$	$${59.71}$$ < $${66.42}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.07}$$ < $${7.12}$$	$${-0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${+0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${0}$$	$${38.5}$$ < $${39.3}$$	$${+0}$$	$${14.88}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${-0}$$	$${37.18}$$ < $${37.94}$$	$${-0}$$	$${14.32}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${-0}$$	$${29.72}$$ < $${30.53}$$	$${-0}$$	$${7.84}$$ < $${8.75}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${28.24}$$ < $${29.11}$$	$${-0}$$	$${6.78}$$ < $${7.71}$$
✅	dogstatsd_rpm_amd64	$${-0}$$	$${29.72}$$ < $${30.53}$$	$${+0}$$	$${7.86}$$ < $${8.76}$$
✅	dogstatsd_suse_amd64	$${-0}$$	$${29.72}$$ < $${30.53}$$	$${+0}$$	$${7.86}$$ < $${8.76}$$
✅	iot_agent_deb_amd64	$${0}$$	$${42.47}$$ < $${43.19}$$	$${-0}$$	$${11.09}$$ < $${11.98}$$
✅	iot_agent_deb_arm64	$${0}$$	$${40.21}$$ < $${40.92}$$	$${-0}$$	$${9.55}$$ < $${10.45}$$
✅	iot_agent_deb_armhf	$${0}$$	$${40.13}$$ < $${40.86}$$	$${-0.01}$$	$${9.66}$$ < $${10.56}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${42.47}$$ < $${43.19}$$	$${-0}$$	$${11.11}$$ < $${12.0}$$
✅	iot_agent_suse_amd64	$${0}$$	$${42.47}$$ < $${43.19}$$	$${-0}$$	$${11.11}$$ < $${12.0}$$

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 1056a182-ff85-4321-bac1-999f0155dc66

Baseline: ed88b88
Comparison: 74fb0cf
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-0.15	[-3.08, +2.78]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+3.33	[+1.88, +4.78]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	+2.41	[+2.29, +2.52]	1	Logs
➖	ddot_logs	memory utilization	+0.39	[+0.32, +0.46]	1	Logs
➖	file_tree	memory utilization	+0.29	[+0.24, +0.33]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	+0.28	[+0.07, +0.48]	1	Logs
➖	quality_gate_idle	memory utilization	+0.27	[+0.22, +0.32]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.20	[+0.15, +0.25]	1	Logs
➖	ddot_metrics	memory utilization	+0.17	[-0.03, +0.37]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.16	[+0.02, +0.30]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.06	[-0.34, +0.47]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.05	[-0.00, +0.10]	1	Logs bounds checks dashboard
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.08, +0.08]	1	Logs
➖	docker_containers_memory	memory utilization	-0.00	[-0.09, +0.09]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	-0.01	[-0.14, +0.13]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.14, +0.11]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.02	[-0.06, +0.03]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.04	[-0.41, +0.34]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.06	[-0.46, +0.35]	1	Logs
➖	docker_containers_cpu	% cpu utilization	-0.15	[-3.08, +2.78]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	-0.25	[-0.40, -0.11]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	-0.36	[-0.59, -0.12]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.59	[-0.68, -0.49]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	-1.19	[-1.38, -0.99]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	lost_bytes	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.