Skip to content

Conversation

@bitomaxsp
Copy link
Contributor

@bitomaxsp bitomaxsp commented Jan 12, 2026

What does this PR do?

Rename kubernetes_kube_service_new_behavior to kubernetes_always_tag_kube_service

Motivation

New name better reflects the behavior.

Describe how you validated your changes

Additional Notes

@bitomaxsp bitomaxsp requested review from a team as code owners January 12, 2026 10:32
@bitomaxsp bitomaxsp requested a review from dustmop January 12, 2026 10:32
@bitomaxsp bitomaxsp self-assigned this Jan 12, 2026
@bitomaxsp bitomaxsp added the qa/done QA done before merge and regressions are covered by tests label Jan 12, 2026
@github-actions github-actions bot added team/agent-build medium review PR review might take time labels Jan 12, 2026
@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 340919a
📊 Static Quality Gates Dashboard

31 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 705.841 MiB
agent_deb_amd64_fips 701.138 MiB
agent_heroku_amd64 326.864 MiB
agent_msi 571.327 MiB
agent_rpm_amd64 705.828 MiB
agent_rpm_amd64_fips 701.125 MiB
agent_rpm_arm64 687.325 MiB
agent_rpm_arm64_fips 683.466 MiB
agent_suse_amd64 705.828 MiB
agent_suse_amd64_fips 701.125 MiB
agent_suse_arm64 687.325 MiB
agent_suse_arm64_fips 683.466 MiB
docker_agent_amd64 767.576 MiB
docker_agent_arm64 773.693 MiB
docker_agent_jmx_amd64 958.454 MiB
docker_agent_jmx_arm64 953.291 MiB
docker_cluster_agent_amd64 180.761 MiB
docker_cluster_agent_arm64 196.618 MiB
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 38.785 MiB
docker_dogstatsd_arm64 37.128 MiB
dogstatsd_deb_amd64 30.004 MiB
dogstatsd_deb_arm64 28.156 MiB
dogstatsd_rpm_amd64 30.004 MiB
dogstatsd_suse_amd64 30.004 MiB
iot_agent_deb_amd64 43.002 MiB
iot_agent_deb_arm64 40.123 MiB
iot_agent_deb_armhf 40.704 MiB
iot_agent_rpm_amd64 43.003 MiB
iot_agent_suse_amd64 43.003 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -27.18 KiB (0.02% reduction) 173.537 → 173.511 → 174.490
agent_deb_amd64_fips neutral 172.424 MiB
agent_heroku_amd64 neutral 87.109 MiB
agent_msi -4.0 KiB (0.00% reduction) 142.863 → 142.859 → 143.020
agent_rpm_amd64 +11.62 KiB (0.01% increase) 176.140 → 176.151 → 177.660
agent_rpm_amd64_fips -3.27 KiB (0.00% reduction) 175.349 → 175.346 → 176.600
agent_rpm_arm64 -10.77 KiB (0.01% reduction) 159.559 → 159.548 → 161.260
agent_rpm_arm64_fips -34.79 KiB (0.02% reduction) 158.910 → 158.876 → 160.550
agent_suse_amd64 +11.62 KiB (0.01% increase) 176.140 → 176.151 → 177.660
agent_suse_amd64_fips -3.27 KiB (0.00% reduction) 175.349 → 175.346 → 176.600
agent_suse_arm64 -10.77 KiB (0.01% reduction) 159.559 → 159.548 → 161.260
agent_suse_arm64_fips -34.79 KiB (0.02% reduction) 158.910 → 158.876 → 160.550
docker_agent_amd64 +2.11 KiB (0.00% increase) 261.164 → 261.166 → 262.450
docker_agent_arm64 -2.13 KiB (0.00% reduction) 250.218 → 250.216 → 252.630
docker_agent_jmx_amd64 neutral 329.801 MiB
docker_agent_jmx_arm64 neutral 314.838 MiB
docker_cluster_agent_amd64 neutral 63.849 MiB
docker_cluster_agent_arm64 neutral 60.147 MiB
docker_cws_instrumentation_amd64 neutral 2.994 MiB
docker_cws_instrumentation_arm64 neutral 2.726 MiB
docker_dogstatsd_amd64 neutral 15.017 MiB
docker_dogstatsd_arm64 neutral 14.348 MiB
dogstatsd_deb_amd64 neutral 7.938 MiB
dogstatsd_deb_arm64 neutral 6.816 MiB
dogstatsd_rpm_amd64 neutral 7.949 MiB
dogstatsd_suse_amd64 neutral 7.949 MiB
iot_agent_deb_amd64 neutral 11.262 MiB
iot_agent_deb_arm64 neutral 9.633 MiB
iot_agent_deb_armhf neutral 9.827 MiB
iot_agent_rpm_amd64 +2.05 KiB (0.02% increase) 11.278 → 11.280 → 12.060
iot_agent_suse_amd64 +2.05 KiB (0.02% increase) 11.278 → 11.280 → 12.060

@cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 2d3724ba-8fbf-48ef-b90c-cee98f0f0429

Baseline: 340919a
Comparison: 1c16dea
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -0.76 [-3.68, +2.16] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_metrics_logs memory utilization +1.08 [+0.87, +1.29] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulative memory utilization +0.92 [+0.76, +1.08] 1 Logs
ddot_metrics memory utilization +0.71 [+0.48, +0.93] 1 Logs
otlp_ingest_metrics memory utilization +0.33 [+0.17, +0.49] 1 Logs
quality_gate_idle_all_features memory utilization +0.31 [+0.27, +0.34] 1 Logs bounds checks dashboard
file_tree memory utilization +0.27 [+0.21, +0.33] 1 Logs
docker_containers_memory memory utilization +0.20 [+0.12, +0.27] 1 Logs
otlp_ingest_logs memory utilization +0.13 [+0.02, +0.23] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.04 [-0.01, +0.08] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.38, +0.41] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.07, +0.08] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.13, +0.14] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.13, +0.11] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.04 [-0.42, +0.33] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.04 [-0.47, +0.38] 1 Logs
ddot_metrics_sum_delta memory utilization -0.12 [-0.31, +0.08] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.12 [-0.35, +0.11] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.17 [-0.22, -0.11] 1 Logs
ddot_logs memory utilization -0.20 [-0.26, -0.13] 1 Logs
quality_gate_idle memory utilization -0.20 [-0.25, -0.16] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.32 [-0.40, -0.25] 1 Logs
docker_containers_cpu % cpu utilization -0.76 [-3.68, +2.16] 1 Logs
quality_gate_logs % cpu utilization -1.70 [-3.15, -0.26] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@bitomaxsp
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jan 12, 2026

View all feedbacks in Devflow UI.

2026-01-12 12:01:53 UTC ℹ️ Start processing command /merge


2026-01-12 12:01:59 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-01-12 16:02:15 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@bitomaxsp
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jan 12, 2026

View all feedbacks in Devflow UI.

2026-01-12 16:05:41 UTC ℹ️ Start processing command /merge


2026-01-12 16:06:00 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-01-12 20:06:19 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

Copy link
Contributor

@rahulkaukuntla rahulkaukuntla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from agent configuration, just make sure that no one is using the old setting name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants