Skip to content

Conversation

@coignetp
Copy link
Contributor

@coignetp coignetp commented Jan 12, 2026

This pull request makes a targeted improvement to the way JMX instance sources are labeled in the JmxScheduler. The main change is to ensure that each JMX instance's Source field is uniquely identified by appending its index, which helps distinguish between multiple instances from the same config.

Key change:

  • The Source field for each JMX instance in the scheduler is now set to include the instance index (e.g., source[0], source[1]), making it easier to differentiate between instances from the same integration config.

Follow the same pattern as other integrations

@github-actions github-actions bot added team/agent-metric-pipelines short review PR is simple enough to be reviewed quickly labels Jan 12, 2026
@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 439be75
📊 Static Quality Gates Dashboard

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +79.09 KiB (0.01% increase) 705.156 → 705.233 → 708.410
agent_deb_amd64_fips +75.09 KiB (0.01% increase) 700.453 → 700.526 → 704.000
agent_heroku_amd64 +23.9 KiB (0.01% increase) 326.864 → 326.887 → 329.530
agent_msi +88.21 KiB (0.02% increase) 571.328 → 571.414 → 982.080
agent_rpm_amd64 +79.09 KiB (0.01% increase) 705.142 → 705.220 → 708.380
agent_rpm_amd64_fips +75.09 KiB (0.01% increase) 700.439 → 700.513 → 703.990
agent_rpm_arm64 +55.67 KiB (0.01% increase) 686.706 → 686.761 → 693.520
agent_rpm_arm64_fips +59.67 KiB (0.01% increase) 682.843 → 682.902 → 688.480
agent_suse_amd64 +79.09 KiB (0.01% increase) 705.142 → 705.220 → 708.380
agent_suse_amd64_fips +75.09 KiB (0.01% increase) 700.439 → 700.513 → 703.990
agent_suse_arm64 +55.67 KiB (0.01% increase) 686.706 → 686.761 → 693.520
agent_suse_arm64_fips +59.67 KiB (0.01% increase) 682.843 → 682.902 → 688.480
docker_agent_amd64 +71.06 KiB (0.01% increase) 767.389 → 767.458 → 770.720
docker_agent_arm64 +55.63 KiB (0.01% increase) 773.555 → 773.609 → 780.200
docker_agent_jmx_amd64 +71.06 KiB (0.01% increase) 958.267 → 958.336 → 961.600
docker_agent_jmx_arm64 +55.64 KiB (0.01% increase) 953.153 → 953.207 → 959.800
docker_cluster_agent_amd64 +12.03 KiB (0.01% increase) 180.761 → 180.773 → 181.080
docker_dogstatsd_amd64 +16.03 KiB (0.04% increase) 38.785 → 38.800 → 39.380
docker_dogstatsd_arm64 -63.97 KiB (0.17% reduction) 37.128 → 37.065 → 37.940
dogstatsd_deb_amd64 +16.03 KiB (0.05% increase) 30.004 → 30.019 → 30.610
dogstatsd_deb_arm64 +12.03 KiB (0.04% increase) 28.156 → 28.168 → 29.110
dogstatsd_rpm_amd64 +16.03 KiB (0.05% increase) 30.004 → 30.019 → 30.610
dogstatsd_suse_amd64 +16.03 KiB (0.05% increase) 30.004 → 30.019 → 30.610
iot_agent_deb_amd64 +12.03 KiB (0.03% increase) 43.002 → 43.014 → 43.290
iot_agent_deb_arm64 +12.03 KiB (0.03% increase) 40.123 → 40.135 → 40.920
iot_agent_deb_armhf +12.02 KiB (0.03% increase) 40.704 → 40.716 → 41.030
iot_agent_rpm_amd64 +12.03 KiB (0.03% increase) 43.003 → 43.015 → 43.290
iot_agent_suse_amd64 +12.03 KiB (0.03% increase) 43.003 → 43.015 → 43.290
3 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
docker_cluster_agent_arm64 196.618 MiB
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -5.33 KiB (0.00% reduction) 173.326 → 173.321 → 174.490
agent_deb_amd64_fips +10.52 KiB (0.01% increase) 172.239 → 172.250 → 173.750
agent_heroku_amd64 +6.27 KiB (0.01% increase) 87.110 → 87.116 → 88.450
agent_msi +16.0 KiB (0.01% increase) 142.867 → 142.883 → 143.020
agent_rpm_amd64 +15.46 KiB (0.01% increase) 176.135 → 176.150 → 177.660
agent_rpm_amd64_fips +63.37 KiB (0.04% increase) 174.918 → 174.980 → 176.600
agent_rpm_arm64 -18.23 KiB (0.01% reduction) 159.368 → 159.351 → 161.260
agent_rpm_arm64_fips +21.46 KiB (0.01% increase) 158.775 → 158.796 → 160.550
agent_suse_amd64 +15.46 KiB (0.01% increase) 176.135 → 176.150 → 177.660
agent_suse_amd64_fips +63.37 KiB (0.04% increase) 174.918 → 174.980 → 176.600
agent_suse_arm64 -18.23 KiB (0.01% reduction) 159.368 → 159.351 → 161.260
agent_suse_arm64_fips +21.46 KiB (0.01% increase) 158.775 → 158.796 → 160.550
docker_agent_amd64 +15.9 KiB (0.01% increase) 261.028 → 261.043 → 262.450
docker_agent_arm64 +11.95 KiB (0.00% increase) 250.070 → 250.082 → 252.630
docker_agent_jmx_amd64 +8.7 KiB (0.00% increase) 329.664 → 329.673 → 331.080
docker_agent_jmx_arm64 +17.71 KiB (0.01% increase) 314.691 → 314.709 → 317.270
docker_cluster_agent_amd64 +11.83 KiB (0.02% increase) 63.849 → 63.861 → 64.490
docker_cluster_agent_arm64 neutral 60.148 MiB
docker_cws_instrumentation_amd64 neutral 2.994 MiB
docker_cws_instrumentation_arm64 neutral 2.726 MiB
docker_dogstatsd_amd64 +6.92 KiB (0.05% increase) 15.017 → 15.023 → 15.820
docker_dogstatsd_arm64 -4.87 KiB (0.03% reduction) 14.348 → 14.343 → 14.830
dogstatsd_deb_amd64 +4.66 KiB (0.06% increase) 7.938 → 7.943 → 8.790
dogstatsd_deb_arm64 +5.07 KiB (0.07% increase) 6.816 → 6.821 → 7.710
dogstatsd_rpm_amd64 +3.28 KiB (0.04% increase) 7.949 → 7.952 → 8.800
dogstatsd_suse_amd64 +3.28 KiB (0.04% increase) 7.949 → 7.952 → 8.800
iot_agent_deb_amd64 +4.5 KiB (0.04% increase) 11.265 → 11.269 → 12.040
iot_agent_deb_arm64 +2.17 KiB (0.02% increase) 9.633 → 9.635 → 10.450
iot_agent_deb_armhf +5.11 KiB (0.05% increase) 9.824 → 9.829 → 10.620
iot_agent_rpm_amd64 +6.8 KiB (0.06% increase) 11.279 → 11.285 → 12.060
iot_agent_suse_amd64 +6.8 KiB (0.06% increase) 11.279 → 11.285 → 12.060

@cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c3a4a568-6b81-4b7d-b2b4-53276fb7ff21

Baseline: 59e667e
Comparison: bbb6173
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -2.41 [-5.28, +0.45] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_metrics memory utilization +0.53 [+0.37, +0.68] 1 Logs
file_tree memory utilization +0.26 [+0.21, +0.31] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.12 [-0.10, +0.35] 1 Logs
quality_gate_idle memory utilization +0.10 [+0.05, +0.14] 1 Logs bounds checks dashboard
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.03, +0.06] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.01 [-0.12, +0.15] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.08, +0.07] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.13, +0.12] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.44, +0.40] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.04 [-0.46, +0.39] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.06 [-0.44, +0.31] 1 Logs
quality_gate_idle_all_features memory utilization -0.10 [-0.13, -0.06] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization -0.14 [-0.23, -0.06] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.16 [-0.21, -0.10] 1 Logs
ddot_metrics_sum_delta memory utilization -0.18 [-0.38, +0.02] 1 Logs
ddot_logs memory utilization -0.19 [-0.26, -0.12] 1 Logs
docker_containers_memory memory utilization -0.24 [-0.31, -0.17] 1 Logs
ddot_metrics memory utilization -0.33 [-0.55, -0.11] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.51 [-0.66, -0.35] 1 Logs
quality_gate_metrics_logs memory utilization -1.29 [-1.50, -1.08] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -1.44 [-1.53, -1.35] 1 Logs
quality_gate_logs % cpu utilization -2.18 [-3.64, -0.72] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization -2.41 [-5.28, +0.45] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants