[WIP] fix irgen issues with line reader

[ajwerner]

Attempts to enforce that we generate legit ir programs for all the symbols we might care about. Also attempts to fix some uncovered bugs. There are still issues with the line reader for a number of subprograms (though fewer than before these fixes).

[agent-platform-auto-pr]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 0cbd517
📊 Static Quality Gates Dashboard

31 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	705.155 MiB
✅	agent_deb_amd64_fips	700.452 MiB
✅	agent_heroku_amd64	326.864 MiB
✅	agent_msi	571.328 MiB
✅	agent_rpm_amd64	705.142 MiB
✅	agent_rpm_amd64_fips	700.439 MiB
✅	agent_rpm_arm64	686.706 MiB
✅	agent_rpm_arm64_fips	682.843 MiB
✅	agent_suse_amd64	705.142 MiB
✅	agent_suse_amd64_fips	700.439 MiB
✅	agent_suse_arm64	686.706 MiB
✅	agent_suse_arm64_fips	682.843 MiB
✅	docker_agent_amd64	767.388 MiB
✅	docker_agent_arm64	773.554 MiB
✅	docker_agent_jmx_amd64	958.266 MiB
✅	docker_agent_jmx_arm64	953.152 MiB
✅	docker_cluster_agent_amd64	180.761 MiB
✅	docker_cluster_agent_arm64	196.618 MiB
✅	docker_cws_instrumentation_amd64	7.135 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_dogstatsd_amd64	38.785 MiB
✅	docker_dogstatsd_arm64	37.128 MiB
✅	dogstatsd_deb_amd64	30.004 MiB
✅	dogstatsd_deb_arm64	28.156 MiB
✅	dogstatsd_rpm_amd64	30.004 MiB
✅	dogstatsd_suse_amd64	30.004 MiB
✅	iot_agent_deb_amd64	43.002 MiB
✅	iot_agent_deb_arm64	40.123 MiB
✅	iot_agent_deb_armhf	40.704 MiB
✅	iot_agent_rpm_amd64	43.003 MiB
✅	iot_agent_suse_amd64	43.003 MiB

On-wire sizes (compressed)

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	+9.46 KiB (0.01% increase)	173.301 → 173.310 → 174.490
✅	agent_deb_amd64_fips	+21.88 KiB (0.01% increase)	172.225 → 172.247 → 173.750
✅	agent_heroku_amd64	neutral	87.107 MiB
✅	agent_msi	-12.0 KiB (0.01% reduction)	142.852 → 142.840 → 143.020
✅	agent_rpm_amd64	+2.44 KiB (0.00% increase)	176.116 → 176.118 → 177.660
✅	agent_rpm_amd64_fips	-31.51 KiB (0.02% reduction)	174.919 → 174.888 → 176.600
✅	agent_rpm_arm64	-29.93 KiB (0.02% reduction)	159.362 → 159.333 → 161.260
✅	agent_rpm_arm64_fips	+17.26 KiB (0.01% increase)	158.747 → 158.764 → 160.550
✅	agent_suse_amd64	+2.44 KiB (0.00% increase)	176.116 → 176.118 → 177.660
✅	agent_suse_amd64_fips	-31.51 KiB (0.02% reduction)	174.919 → 174.888 → 176.600
✅	agent_suse_arm64	-29.93 KiB (0.02% reduction)	159.362 → 159.333 → 161.260
✅	agent_suse_arm64_fips	+17.26 KiB (0.01% increase)	158.747 → 158.764 → 160.550
✅	docker_agent_amd64	neutral	261.024 MiB
✅	docker_agent_arm64	neutral	250.071 MiB
✅	docker_agent_jmx_amd64	-2.89 KiB (0.00% reduction)	329.661 → 329.659 → 331.080
✅	docker_agent_jmx_arm64	-5.08 KiB (0.00% reduction)	314.693 → 314.688 → 317.270
✅	docker_cluster_agent_amd64	neutral	63.849 MiB
✅	docker_cluster_agent_arm64	neutral	60.147 MiB
✅	docker_cws_instrumentation_amd64	neutral	2.994 MiB
✅	docker_cws_instrumentation_arm64	neutral	2.726 MiB
✅	docker_dogstatsd_amd64	neutral	15.017 MiB
✅	docker_dogstatsd_arm64	neutral	14.342 MiB
✅	dogstatsd_deb_amd64	neutral	7.938 MiB
✅	dogstatsd_deb_arm64	neutral	6.816 MiB
✅	dogstatsd_rpm_amd64	neutral	7.949 MiB
✅	dogstatsd_suse_amd64	neutral	7.949 MiB
✅	iot_agent_deb_amd64	neutral	11.263 MiB
✅	iot_agent_deb_arm64	neutral	9.634 MiB
✅	iot_agent_deb_armhf	neutral	9.825 MiB
✅	iot_agent_rpm_amd64	neutral	11.279 MiB
✅	iot_agent_suse_amd64	neutral	11.279 MiB

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 220258e1-432e-4002-9b9e-e543d40f18c6

Baseline: 0cbd517
Comparison: ed7ff18
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+0.02	[-2.93, +2.96]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_memory	memory utilization	+1.14	[+0.98, +1.29]	1	Logs
➖	file_tree	memory utilization	+0.31	[+0.26, +0.36]	1	Logs
➖	quality_gate_logs	% cpu utilization	+0.25	[-1.24, +1.75]	1	Logs bounds checks dashboard
➖	otlp_ingest_metrics	memory utilization	+0.24	[+0.09, +0.40]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.02	[-0.40, +0.44]	1	Logs
➖	docker_containers_cpu	% cpu utilization	+0.02	[-2.93, +2.96]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.02	[-0.21, +0.24]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	+0.01	[-0.13, +0.15]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	+0.01	[-0.19, +0.21]	1	Logs bounds checks dashboard
➖	file_to_blackhole_500ms_latency	egress throughput	+0.01	[-0.36, +0.38]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.08, +0.08]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.00	[-0.42, +0.42]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.13, +0.12]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.02	[-0.12, +0.08]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.04	[-0.08, +0.01]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	-0.08	[-0.29, +0.13]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	-0.11	[-0.26, +0.05]	1	Logs
➖	quality_gate_idle	memory utilization	-0.13	[-0.17, -0.08]	1	Logs bounds checks dashboard
➖	ddot_logs	memory utilization	-0.21	[-0.29, -0.13]	1	Logs
➖	ddot_metrics	memory utilization	-0.28	[-0.51, -0.05]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.29	[-0.33, -0.26]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.33	[-0.39, -0.28]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.88	[-0.95, -0.81]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	lost_bytes	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.