Optional tags can remove expected tags in assertTags

[triviajon]

What does this PR do?

This PR allows users to remove tags from expectedTags by adding the tag to the optionalTags list. So tags that appear in both list should be treated as optional (i.e., may be missing from actualTags). Tags that only appear in expectedTags must appear in actualTags. And then when acceptUnexpectedTags=false, we retain the original behavior that we allow some optionalTags to show up.

Motivation

We want to mark some tags as optional in the Kubernetes test suite depending on the environment we are running in, but we don't want to add a bunch of conditionals changing the tag list for each test. This solution seems to be the easiest way to later be able to say "in general, we want these tags, but if we're running in OpenShift, don't worry about these specific tags."

Describe how you validated your changes

This should be a no-op right now. I've added a unit test to test the behavior of assertTags, and the CI should also verify.

Additional Notes

[agent-platform-auto-pr]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 0cbd517
📊 Static Quality Gates Dashboard

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	+167.3 KiB (0.02% increase)	705.156 → 705.319 → 708.410
✅	agent_deb_amd64_fips	+151.3 KiB (0.02% increase)	700.453 → 700.601 → 704.000
✅	agent_heroku_amd64	+56.11 KiB (0.02% increase)	326.864 → 326.919 → 329.530
✅	agent_msi	+129.43 KiB (0.02% increase)	571.328 → 571.454 → 982.080
✅	agent_rpm_amd64	+167.3 KiB (0.02% increase)	705.142 → 705.306 → 708.380
✅	agent_rpm_amd64_fips	+151.3 KiB (0.02% increase)	700.439 → 700.587 → 703.990
✅	agent_rpm_arm64	+187.88 KiB (0.03% increase)	686.706 → 686.890 → 693.520
✅	agent_rpm_arm64_fips	+131.88 KiB (0.02% increase)	682.843 → 682.972 → 688.480
✅	agent_suse_amd64	+167.3 KiB (0.02% increase)	705.142 → 705.306 → 708.380
✅	agent_suse_amd64_fips	+151.3 KiB (0.02% increase)	700.439 → 700.587 → 703.990
✅	agent_suse_arm64	+187.88 KiB (0.03% increase)	686.706 → 686.890 → 693.520
✅	agent_suse_arm64_fips	+131.88 KiB (0.02% increase)	682.843 → 682.972 → 688.480
✅	docker_agent_amd64	+147.27 KiB (0.02% increase)	767.389 → 767.532 → 770.720
✅	docker_agent_arm64	+123.85 KiB (0.02% increase)	773.555 → 773.676 → 780.200
✅	docker_agent_jmx_amd64	+147.26 KiB (0.02% increase)	958.267 → 958.411 → 961.600
✅	docker_agent_jmx_arm64	+123.85 KiB (0.01% increase)	953.153 → 953.274 → 959.800
✅	docker_cluster_agent_amd64	+28.04 KiB (0.02% increase)	180.761 → 180.788 → 181.080
✅	docker_dogstatsd_amd64	+24.03 KiB (0.06% increase)	38.785 → 38.808 → 39.380
✅	dogstatsd_deb_amd64	+28.03 KiB (0.09% increase)	30.004 → 30.031 → 30.610
✅	dogstatsd_deb_arm64	+20.03 KiB (0.07% increase)	28.156 → 28.176 → 29.110
✅	dogstatsd_rpm_amd64	+28.03 KiB (0.09% increase)	30.004 → 30.031 → 30.610
✅	dogstatsd_suse_amd64	+28.03 KiB (0.09% increase)	30.004 → 30.031 → 30.610
✅	iot_agent_deb_amd64	+36.03 KiB (0.08% increase)	43.002 → 43.037 → 43.290
✅	iot_agent_deb_arm64	+32.03 KiB (0.08% increase)	40.123 → 40.155 → 40.920
✅	iot_agent_deb_armhf	+32.02 KiB (0.08% increase)	40.704 → 40.736 → 41.030
✅	iot_agent_rpm_amd64	+36.03 KiB (0.08% increase)	43.003 → 43.038 → 43.290
✅	iot_agent_suse_amd64	+36.03 KiB (0.08% increase)	43.003 → 43.038 → 43.290

4 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	docker_cluster_agent_arm64	196.618 MiB
✅	docker_cws_instrumentation_amd64	7.135 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_dogstatsd_arm64	37.128 MiB

On-wire sizes (compressed)

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	+67.92 KiB (0.04% increase)	173.301 → 173.368 → 174.490
✅	agent_deb_amd64_fips	+46.47 KiB (0.03% increase)	172.225 → 172.271 → 173.750
✅	agent_heroku_amd64	+5.24 KiB (0.01% increase)	87.107 → 87.112 → 88.450
✅	agent_msi	+56.0 KiB (0.04% increase)	142.852 → 142.906 → 143.020
✅	agent_rpm_amd64	neutral	176.116 MiB
✅	agent_rpm_amd64_fips	+120.29 KiB (0.07% increase)	174.919 → 175.036 → 176.600
✅	agent_rpm_arm64	+37.89 KiB (0.02% increase)	159.362 → 159.399 → 161.260
✅	agent_rpm_arm64_fips	-34.84 KiB (0.02% reduction)	158.747 → 158.713 → 160.550
✅	agent_suse_amd64	neutral	176.116 MiB
✅	agent_suse_amd64_fips	+120.29 KiB (0.07% increase)	174.919 → 175.036 → 176.600
✅	agent_suse_arm64	+37.89 KiB (0.02% increase)	159.362 → 159.399 → 161.260
✅	agent_suse_arm64_fips	-34.84 KiB (0.02% reduction)	158.747 → 158.713 → 160.550
✅	docker_agent_amd64	+52.27 KiB (0.02% increase)	261.025 → 261.076 → 262.450
✅	docker_agent_arm64	+36.83 KiB (0.01% increase)	250.071 → 250.107 → 252.630
✅	docker_agent_jmx_amd64	+54.2 KiB (0.02% increase)	329.661 → 329.714 → 331.080
✅	docker_agent_jmx_arm64	+35.42 KiB (0.01% increase)	314.693 → 314.727 → 317.270
✅	docker_cluster_agent_amd64	+28.46 KiB (0.04% increase)	63.849 → 63.877 → 64.490
✅	docker_cluster_agent_arm64	+13.05 KiB (0.02% increase)	60.147 → 60.160 → 61.170
✅	docker_cws_instrumentation_amd64	neutral	2.994 MiB
✅	docker_cws_instrumentation_arm64	neutral	2.726 MiB
✅	docker_dogstatsd_amd64	+9.7 KiB (0.06% increase)	15.017 → 15.026 → 15.820
✅	docker_dogstatsd_arm64	+9.2 KiB (0.06% increase)	14.342 → 14.351 → 14.830
✅	dogstatsd_deb_amd64	+7.73 KiB (0.10% increase)	7.937 → 7.945 → 8.790
✅	dogstatsd_deb_arm64	+8.73 KiB (0.13% increase)	6.815 → 6.824 → 7.710
✅	dogstatsd_rpm_amd64	+7.53 KiB (0.09% increase)	7.949 → 7.956 → 8.800
✅	dogstatsd_suse_amd64	+7.53 KiB (0.09% increase)	7.949 → 7.956 → 8.800
✅	iot_agent_deb_amd64	+11.25 KiB (0.10% increase)	11.264 → 11.275 → 12.040
✅	iot_agent_deb_arm64	+7.72 KiB (0.08% increase)	9.634 → 9.641 → 10.450
✅	iot_agent_deb_armhf	+7.21 KiB (0.07% increase)	9.827 → 9.834 → 10.620
✅	iot_agent_rpm_amd64	+16.54 KiB (0.14% increase)	11.278 → 11.294 → 12.060
✅	iot_agent_suse_amd64	+16.54 KiB (0.14% increase)	11.278 → 11.294 → 12.060

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a834b56f-a4a8-4a02-b6e8-c76bd966f8ce

Baseline: a991a9c
Comparison: d665c87
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-2.84	[-5.74, +0.05]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+2.00	[+0.52, +3.49]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	+1.07	[+0.86, +1.28]	1	Logs bounds checks dashboard
➖	otlp_ingest_logs	memory utilization	+0.95	[+0.84, +1.06]	1	Logs
➖	ddot_metrics	memory utilization	+0.33	[+0.11, +0.54]	1	Logs
➖	quality_gate_idle	memory utilization	+0.13	[+0.08, +0.18]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	+0.05	[-0.00, +0.11]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	+0.02	[-0.11, +0.14]	1	Logs
➖	ddot_logs	memory utilization	+0.01	[-0.06, +0.08]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.01	[-0.40, +0.41]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.07, +0.08]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.00	[-0.38, +0.37]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.13, +0.12]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.02	[-0.06, +0.03]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.04	[-0.45, +0.38]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.07	[-0.14, +0.01]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.08	[-0.12, -0.05]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.12	[-0.17, -0.07]	1	Logs
➖	docker_containers_memory	memory utilization	-0.21	[-0.28, -0.13]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	-0.25	[-0.45, -0.05]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-0.35	[-0.50, -0.19]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	-0.59	[-0.82, -0.36]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	-0.81	[-0.98, -0.65]	1	Logs
➖	docker_containers_cpu	% cpu utilization	-2.84	[-5.74, +0.05]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	lost_bytes	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[L3n41c]

Can you clarify what’s the intent of this change?

According to the test, it seems that we want to change the behavior for the cases where a tag is both expected (mandatory) and optional.
From a user point of view, it’s not clear to me what should be expected for something that is simultaneously mandatory and expected.
I would advocate for avoiding such unclear specifications.

What the code seems to do is to behave as if tags present in both expected and optional lists were present only in the optional list.
But in this case, why not simply avoid putting tags in both lists?