[CNM-5372] Extract VerifyKernelFuncs into pkg/ebpf/ksyms leaf package

[jmw51798]

What does this PR do?

VerifyKernelFuncs and GetKernelSymbolsAddressesNoCache are pure /proc/kallsyms parsers — they have no dependency on the rest of pkg/ebpf (BTF, manager, perf, CO-RE, etc.). Today the 10 callers that only need VerifyKernelFuncs (kernelbugs, modifiers, several tracer subpackages, USM, and the security probe) pull in all of pkg/ebpf as a transitive dep just for these helpers.

Move them into a new leaf package pkg/ebpf/ksyms with no dependency on pkg/ebpf. ksyms_bpf.go stays in pkg/ebpf (it uses LoadCOREAsset) and delegates to the new package.

This also clears the way for an upcoming PR that adds a pkg/ebpf/features import to pkg/ebpf/ebpftest. As of today, that import would close a test-time cycle:

pkg/ebpf (tests) -> ebpftest -> features -> kernelbugs -> pkg/ebpf

With kernelbugs depending on the new leaf package instead of pkg/ebpf, the cycle breaks at its origin.

Motivation

Describe how you validated your changes

CI tests

Additional Notes

[github-actions]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[datadog-datadog-prod-us1-2]

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 3 Pipeline jobs failed

DataDog/datadog-agent | kmt_run_secagent_tests_x64: [ubuntu_18.04, cws_host]     

See error

Data race detected in security tests during execution of TestReplay.

DataDog/datadog-agent | kmt_run_secagent_tests_x64_ad: [ubuntu_22.04, cws_ad]     

See error

6 tests failed: Invalid activity dump and missing or wrong `.protobuf` file at activity_dumps_common.go:62 and Node not found in systemd service security profile at security_profile_test.go:2673.

DataDog/datadog-agent | oracle: [21.3.0-xe]     

See error

Failed to ping Oracle instance: ORA-12514: TNS:listener does not currently know of service requested in connect descriptor.

ℹ️ Info

🎯 Code Coverage (details)
• Patch Coverage: 0.00%
• Overall Coverage: 50.62% (+0.01%)

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7251e21 | Docs | Datadog PR Page | Give us feedback!}

[dd-octo-sts]

Go Package Import Differences

Baseline: 21fed42
Comparison: 7251e21

binary	os	arch	change
system-probe	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/pkg/ebpf/ksyms
system-probe	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/pkg/ebpf/ksyms

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor 21fed42c:

Results for datadog-agent_7.81.0~devel.git.531.7251e21.pipeline.117214546-1_amd64.deb:

No change detected

[dd-octo-sts]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 21fed42
📊 Static Quality Gates Dashboard
🔗 SQG Job

32 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	747.602 MiB
✅	agent_deb_amd64_fips	703.409 MiB
✅	agent_heroku_amd64	311.059 MiB
✅	agent_rpm_amd64	747.585 MiB
✅	agent_rpm_amd64_fips	703.392 MiB
✅	agent_rpm_arm64	724.906 MiB
✅	agent_rpm_arm64_fips	684.065 MiB
✅	agent_suse_amd64	747.585 MiB
✅	agent_suse_amd64_fips	703.392 MiB
✅	agent_suse_arm64	724.906 MiB
✅	agent_suse_arm64_fips	684.065 MiB
✅	docker_agent_amd64	807.613 MiB
✅	docker_agent_arm64	809.758 MiB
✅	docker_agent_jmx_amd64	998.553 MiB
✅	docker_agent_jmx_arm64	989.351 MiB
✅	docker_cluster_agent_amd64	207.788 MiB
✅	docker_cluster_agent_arm64	221.714 MiB
✅	docker_cws_instrumentation_amd64	7.154 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_dogstatsd_amd64	39.472 MiB
✅	docker_dogstatsd_arm64	37.691 MiB
✅	docker_host_profiler_amd64	302.836 MiB
✅	docker_host_profiler_arm64	314.291 MiB
✅	dogstatsd_deb_amd64	30.129 MiB
✅	dogstatsd_deb_arm64	28.247 MiB
✅	dogstatsd_rpm_amd64	30.129 MiB
✅	dogstatsd_suse_amd64	30.129 MiB
✅	iot_agent_deb_amd64	45.004 MiB
✅	iot_agent_deb_arm64	41.930 MiB
✅	iot_agent_deb_armhf	42.652 MiB
✅	iot_agent_rpm_amd64	45.004 MiB
✅	iot_agent_suse_amd64	45.003 MiB

[github-actions]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fbdf23465e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Replace recursive testdata glob

The repo's Bazel review guideline says to flag any glob with a ** pattern because recursive globs skip subdirectories that later contain BUILD files and can make runfiles silently incomplete. Since this test only needs the three kallsyms fixtures under testdata, please enumerate them or use a non-recursive pattern instead of testdata/**.

Useful? React with 👍 / 👎.

[jmw51798]

datadog-agent/bazel/AGENTS.md

Line 276 in ad9017c

- Use `glob(["testdata/**"])` (not bare directory labels) in `data`. A directory label makes the target depend on the

says to use glob with **, so I'm not sure which is correct.

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 75bc6688-7e2d-4534-a38c-a3bf149cf790

Baseline: 21fed42
Comparison: 7251e21
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.18	[+0.07, +2.29]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	+0.74	[+0.69, +0.78]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	+0.48	[+0.23, +0.73]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	-0.06	[-0.11, -0.01]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	145.32MiB ≤ 147MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	732.64KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	483.81MiB ≤ 495MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	1.12MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	178.62MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	264.38MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	405.81 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	389.84MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.93GiB ≤ 1.04GiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment	Variant	Replicates	Failure	Logs	Debug Dashboard
experiment_with_failures	baseline	0 (x8) 1 (x6)	Oom killed		Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment	Variant	Replicates	Failure	Debug Dashboard
quality_gate_idle	baseline	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	baseline	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	comparison	10	Oom killed	Debug Dashboard
quality_gate_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	comparison	10	Oom killed	Debug Dashboard

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

[github-actions]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7251e2158e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Replace recursive testdata glob

For this new Bazel test target, glob(["testdata/**"]) violates the repo's Bazel review guideline, which explicitly disallows recursive globs because they skip subdirectories containing BUILD files and hurt caching/incrementality. Since the testdata files are all directly under this package today, list them explicitly or use a non-recursive pattern such as testdata/*.

Useful? React with 👍 / 👎.