-
Notifications
You must be signed in to change notification settings - Fork 52
Add CreateCustomFramework and UpdateCustomFramework endpoints #2356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CreateCustomFramework and UpdateCustomFramework endpoints #2356
Conversation
| } | ||
|
|
||
| def __init__( | ||
| self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
| self_, | |
| self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
| "name": "name", | ||
| } | ||
|
|
||
| def __init__(self_, controls: List[FrameworkControl], name: str, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
| def __init__(self_, controls: List[FrameworkControl], name: str, **kwargs): | |
| def __init__(self, controls: List[FrameworkControl], name: str, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
| "rule_ids": "rule_ids", | ||
| } | ||
|
|
||
| def __init__(self_, name: str, rule_ids: List[str], **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
| def __init__(self_, name: str, rule_ids: List[str], **kwargs): | |
| def __init__(self, name: str, rule_ids: List[str], **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
2a28745 to
0e90516
Compare
0e90516 to
aa5556c
Compare
| } | ||
|
|
||
| def __init__( | ||
| self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
| self_, | |
| self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
e51f0dd to
0e80887
Compare
0e80887 to
4049c4a
Compare
|
This PR has been automatically marked as stale because it has not had activity in the last 30 days. |
See DataDog/datadog-api-spec#3481
Test branch datadog-api-spec/test/vbarth/add-create-custom-framework