-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Monitor Notification Rules v2 API #2488
base: master
Are you sure you want to change the base?
Add Monitor Notification Rules v2 API #2488
Conversation
"data": "data", | ||
} | ||
|
||
def __init__(self_, data: Union[List[MonitorNotificationRuleData], UnsetType] = unset, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, data: Union[List[MonitorNotificationRuleData], UnsetType] = unset, **kwargs): | |
def __init__(self, data: Union[List[MonitorNotificationRuleData], UnsetType] = unset, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
} | ||
|
||
def __init__( | ||
self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
self_, | |
self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
} | ||
|
||
def __init__( | ||
self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
self_, | |
self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
"data": "data", | ||
} | ||
|
||
def __init__(self_, data: MonitorNotificationRuleCreateRequestData, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, data: MonitorNotificationRuleCreateRequestData, **kwargs): | |
def __init__(self, data: MonitorNotificationRuleCreateRequestData, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
} | ||
|
||
def __init__( | ||
self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
self_, | |
self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
} | ||
|
||
def __init__( | ||
self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
self_, | |
self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
"tags": "tags", | ||
} | ||
|
||
def __init__(self_, tags: List[str], **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, tags: List[str], **kwargs): | |
def __init__(self, tags: List[str], **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
"data": "data", | ||
} | ||
|
||
def __init__(self_, data: Union[MonitorNotificationRuleData, UnsetType] = unset, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, data: Union[MonitorNotificationRuleData, UnsetType] = unset, **kwargs): | |
def __init__(self, data: Union[MonitorNotificationRuleData, UnsetType] = unset, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
} | ||
|
||
def __init__( | ||
self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
self_, | |
self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
"data": "data", | ||
} | ||
|
||
def __init__(self_, data: MonitorNotificationRuleUpdateRequestData, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, data: MonitorNotificationRuleUpdateRequestData, **kwargs): | |
def __init__(self, data: MonitorNotificationRuleUpdateRequestData, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
1ad6a94
to
97a4900
Compare
ade52b2
to
9c6d2af
Compare
9c6d2af
to
59884ac
Compare
See DataDog/datadog-api-spec#3695
Test branch datadog-api-spec/test/shaneyuandd/notification-rule-beta