Only run docker build CI when Dockerfile changes.
#631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaanq
approved these changes
Feb 5, 2025
|
Squashing |
jasonforal
force-pushed
the
jf/docker-build
branch
from
23997fe to
f65e3a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
CI takes longer than necessary to run because compiling a Docker image is relatively time-consuming. We only need to do this test when the
Dockerfileactually changes.What is your solution?
Testing
Look at f65e3a0. Confirm there were no changes to the
Dockerfile. Check the CI run and confirm the "Test Docker Container" job did not run:Look at 23997fe. Confirm there was a change to the
Dockerfile. Check the CI run and confirm the "Test Docker Container" job ran:What the reviewer should know