[PROF-13166] Update to latest upstream changes #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsavoire
commented
Nov 20, 2025
nsavoire
commented
Nov 20, 2025
nsavoire
force-pushed
the
nsavoire/upstream_changes
branch
from
f845e38 to
29f6453
Compare
nsavoire
commented
Nov 20, 2025
| return fmt.Errorf("failed to start map monitors: %w", err) | ||
| } | ||
|
|
||
| _, err := tracehandler.Start(ctx, rep, trc.TraceProcessor(), |
Collaborator
Author
There was a problem hiding this comment.
Need to check if it's worth disabling the frame cache that replaces the trace cache.
nsavoire
commented
Nov 21, 2025
nsavoire
force-pushed
the
nsavoire/upstream_changes
branch
4 times, most recently
from
6beff06 to
a29d857
Compare
nsavoire
changed the title
SymbolMap has been removed, replace it with VisitSymbols.
ExtractAsFile has been removed from Process interface while GetExe and GetProcessMeta have been added
TraceHandler has been removed.
Changes because of string / mapping interning * Strings in traceMetadata has been replaced with libpf.String. * CustomLabels has been replaced with []map[libpf.String]libpf.String. * frame.MappingFile has been replaced with frame.Mapping.
nsavoire
force-pushed
the
nsavoire/upstream_changes
branch
from
a29d857 to
d99e9f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update to latest upstream changes.
Motivation