RUM-13075: Do not send TTID and TTFD vitals if they are too large #3031
+193
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksandr-gringauz
force-pushed
the
aleksandr-gringauz/RUM-13075/cut-off-large-ttid
branch
from
36f6fe1 to
46cb7bc
Compare
aleksandr-gringauz
changed the title
aleksandr-gringauz
changed the title
|
🎯 Code Coverage 🔗 Commit SHA: 46cb7bc | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## aleksandr-gringauz/feature/app-launch-vitals #3031 +/- ##
================================================================================
+ Coverage 71.24% 71.29% +0.05%
================================================================================
Files 861 861
Lines 31659 31684 +25
Branches 5327 5329 +2
================================================================================
+ Hits 22555 22589 +34
+ Misses 7587 7584 -3
+ Partials 1517 1511 -6
🚀 New features to boost your workflow:
|
|
|
||
| internal const val TTFD_TOO_LARGE_MESSAGE = "TTFD value is too large, skipping it" | ||
|
|
||
| internal val MAX_TTID_DURATION_NS: Long = 1.minutes.inWholeNanoseconds |
Contributor
Author
There was a problem hiding this comment.
These thresholds for TTID and TTFD are aligned with iOS https://github.com/DataDog/dd-sdk-ios/blob/bbbab7f42f2acd69b2cd37e1ba8203ca33a2b3d0/DatadogRUM/Sources/RUMMonitor/Scopes/RUMAppLaunchManager.swift#L13
| ) { | ||
| ttidReportedForScenario = true | ||
|
|
||
| rumAppStartupTelemetryReporter.reportTTID( |
Contributor
Author
There was a problem hiding this comment.
We are still sending ttid telemetry event with a large duration. We want to be able to investigate these cases.
Contributor
|
Why to not filter them out on back-end in order to have more flexibility in future? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See description in the linked ticket (RUM-13075).
Also decided to do the same thing for TTFD (not send vital event that has a duration greater than a certain threshold).
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)