Skip to content

[FIX] Fixes silent crash in Session Replay SVG node recorder #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2025
Merged

[FIX] Fixes silent crash in Session Replay SVG node recorder #1040

merged 1 commit into from
Nov 6, 2025

Conversation

@cdn34dd
Copy link
Contributor

@cdn34dd cdn34dd commented Nov 6, 2025

What does this PR do?

Checks if view attributes property exists before accessing it to avoid silent crash.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@cdn34dd cdn34dd requested a review from a team as a code owner November 6, 2025 09:39
@cdn34dd cdn34dd merged commit c94f15c into develop Nov 6, 2025
11 checks passed
@cdn34dd cdn34dd deleted the carlos/fix-svg-node-recorder-exception branch November 6, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbarrio sbarrio sbarrio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cdn34dd @sbarrio