[RUM-11204] [V3][Modularization] Moved WebView legacy implementation to WebView package #981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-saia-datadog
force-pushed
the
marcosaia/RUM-11204/refactor-webview-logic
branch
from
6b9533b to
ffb43c8
Compare
marco-saia-datadog
force-pushed
the
marcosaia/RUM-11204/use-core-sdk-native-instance-on-ios
branch
from
b7a6e5b to
008e733
Compare
sbarrio
force-pushed
the
marcosaia/RUM-11204/use-core-sdk-native-instance-on-ios
branch
from
008e733 to
93aa612
Compare
Base automatically changed from
marcosaia/RUM-11204/use-core-sdk-native-instance-on-ios
to
feature/v3
September 29, 2025 13:34
sbarrio
reviewed
Oct 13, 2025
| } | ||
| } | ||
|
|
||
| class MockOnCoreInitializedListener { |
Contributor
There was a problem hiding this comment.
Nit: Since we renamed the others to onSDKInitializedListener perhaps we should do the same with this one.
sbarrio
reviewed
Oct 13, 2025
| // Pods | ||
| // | ||
| // Created by Marco Saia on 08.09.25. | ||
| // |
Contributor
There was a problem hiding this comment.
Nit: We should use the base Datadog header for this too, right?
sbarrio
approved these changes
Oct 13, 2025
Contributor
sbarrio
left a comment
sbarrio
left a comment
There was a problem hiding this comment.
Left a few minor comments, but it looks fine to me. Nice job!
sbarrio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The core SDK package handles the
consumeWebviewEventfunction that is used to support WebView integration on Android new architecture, using the legacy approach.This PR moves this function to the
@datadog/mobile-react-native-webviewmodule by creating a new Turbo Module.TODO
Review checklist (to be filled by reviewers)