-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement origin detection #3124
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 5222 Passed, 73 Skipped, 1m 55.7s Total Time |
BenchmarksBenchmark execution time: 2025-02-05 15:17:35 Comparing candidate commit 2c8524e in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics. |
814d0ba
to
fa2f8ba
Compare
…ing in the right environment
4d1fceb
to
e657fc8
Compare
system-Tests covering this feature are in progress, but I'm waiting on some help as this feature depends on environment variables and it doesn't seem to be a good way to test these cases in |
b2a9fc1
to
e657fc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What does this PR do?
Origin Detection is a feature that allows the Agent to correctly detect and tag incoming custom metrics or traces with their Origin (AKA container tags).
Origin Detection works by having the client sending additional data to the Agent so the Agent is able to resolve the Origin.
This PR implements the missing external data implementation. External data was implemented as a last resort for Origin Detection in case no other solution would work.
It also updates the
cid-
prefix for the container ID according to the current state of Origin Detection as described in the task's RFC.Reviewer's Checklist
v2-dev
branch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!