Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: manual publish of Service Extension image #3151

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

e-n-0
Copy link
Member

@e-n-0 e-n-0 commented Feb 5, 2025

What does this PR do?

This PR fixes some issues when publishing manually images of the Service Extension.

  • The commit sha selected wasn't properly applied (defaulting to the selected branch everytime)
  • The docker push failed when the set_as_latest was false? The string "false" was evaluated into the command line thus making the process failing

Motivation

Publish release/dev/test image manually by triggering the workflow.

Tests

This was tested locally by running the workflow with the github CLI.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@e-n-0 e-n-0 requested review from a team as code owners February 5, 2025 13:12
@e-n-0 e-n-0 force-pushed the flavien/envoy/fix-publish-images branch from 651e1c7 to 998260a Compare February 5, 2025 13:13
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 5, 2025

Datadog Report

Branch report: flavien/envoy/fix-publish-images
Commit report: 7da4f25
Test service: dd-trace-go

✅ 0 Failed, 5222 Passed, 73 Skipped, 1m 16.26s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 5, 2025

Benchmarks

Benchmark execution time: 2025-02-06 08:35:36

Comparing candidate commit cd0483b in PR branch flavien/envoy/fix-publish-images with baseline commit d5d974f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

@eliottness eliottness force-pushed the flavien/envoy/fix-publish-images branch from 998260a to cd0483b Compare February 6, 2025 08:08
@eliottness eliottness enabled auto-merge (squash) February 6, 2025 08:09
@eliottness eliottness merged commit 5996821 into main Feb 6, 2025
177 checks passed
@eliottness eliottness deleted the flavien/envoy/fix-publish-images branch February 6, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants