Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/gorilla/mux: Add WithStatusCheck() #3166

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

winebarrel
Copy link

@winebarrel winebarrel commented Feb 8, 2025

What does this PR do?

Add WithStatusCheck() to contrib/gorilla/mux so that the function can be passed to httptrace.ServeConfig.IsStatusError.

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

Add WithStatusCheck() to contrib/gorilla/mux so that the function can be
passed to httptrace.ServeConfig.IsStatusError.

Fixes DataDog#2390
@winebarrel winebarrel requested review from a team as code owners February 8, 2025 07:58
Removed unused struct fields and fixed response HTTP code checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contrib/internal/httptrace: proposal: Add option to ignore setting errors for 5xx HTTP status codes
1 participant