-
Notifications
You must be signed in to change notification settings - Fork 492
ci: update slo check and slo notification rules #4172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
It should run even if check-slo-breaches fails. This is how we get notified for breaches.
BenchmarksBenchmark execution time: 2025-11-27 07:28:40 Comparing candidate commit 033aac9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 8 unstable metrics. |
…/apmsp-2373.update-slo-check
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 033aac9 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
|
Converted to draft since I still would like to test if rules are propagated to child pipelines. |
What does this PR do?
workflow: auto_cancel: on_new_commit: interruptible: trueto.gitlab-ci.ymlto always cancel jobs withinterruptible: trueon new commits. 1notify-slo-breachesalways run, regardless of the success or failure ofcheck-slo-breachesto make sure we get warning notifications.Less importantly:
macrobenchmarks.yml, add explanatory comments when needed, fix pre-release gates comment.Motivation
https://datadoghq.atlassian.net/browse/APMSP-2373
In summary:
notify-slo-breachesmust run even whencheck-slo-breachessucceeds (for notifying for warnings).Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!
Footnotes
The default behavior,
conservative, is insufficient. It cancels the pipeline if no jobs withinterruptible: false(the default) have started. If there is a job before benchmarks withinterruptible: falsethat has started, e.g.,wait_for_github_workflow, GitLab won't interrupt those benchmarks. See https://docs.gitlab.com/ci/yaml/#workflowauto_cancelon_new_commit ↩