Skip to content

Conversation

@igoragoli
Copy link
Contributor

@igoragoli igoragoli commented Nov 25, 2025

What does this PR do?

  • Adds workflow: auto_cancel: on_new_commit: interruptible: true to .gitlab-ci.yml to always cancel jobs with interruptible: true on new commits. 1
  • Make notify-slo-breaches always run, regardless of the success or failure of check-slo-breaches to make sure we get warning notifications.

Less importantly:

  • Simplify macrobenchmarks and pre-release gates rules and adds YAML anchors for readability and DRYness.
  • Clean up comments on macrobenchmarks.yml, add explanatory comments when needed, fix pre-release gates comment.

Motivation

https://datadoghq.atlassian.net/browse/APMSP-2373

In summary:

  • Previous interruptible policies were incomplete.
  • notify-slo-breaches must run even when check-slo-breaches succeeds (for notifying for warnings).

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

Footnotes

  1. The default behavior, conservative, is insufficient. It cancels the pipeline if no jobs with interruptible: false (the default) have started. If there is a job before benchmarks with interruptible: false that has started, e.g., wait_for_github_workflow, GitLab won't interrupt those benchmarks. See https://docs.gitlab.com/ci/yaml/#workflowauto_cancelon_new_commit

@pr-commenter
Copy link

pr-commenter bot commented Nov 25, 2025

Benchmarks

Benchmark execution time: 2025-11-27 07:28:40

Comparing candidate commit 033aac9 in PR branch augusto/apmsp-2373.update-slo-check with baseline commit 6503799 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 8 unstable metrics.

@igoragoli igoragoli changed the title ci: update slo check and slo notification execution conditions ci: update slo check and slo notification rules Nov 25, 2025
@igoragoli igoragoli marked this pull request as ready for review November 25, 2025 14:17
@igoragoli igoragoli requested a review from a team as a code owner November 25, 2025 14:17
@igoragoli igoragoli marked this pull request as draft November 25, 2025 14:18
@datadog-official
Copy link
Contributor

datadog-official bot commented Nov 26, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 033aac9 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@igoragoli igoragoli marked this pull request as ready for review November 27, 2025 07:14
@igoragoli igoragoli requested a review from a team as a code owner November 27, 2025 07:14
@igoragoli igoragoli marked this pull request as draft November 28, 2025 13:58
@igoragoli
Copy link
Contributor Author

Converted to draft since I still would like to test if rules are propagated to child pipelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants