-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix couchbase flaky test (cleanup phase) #7598
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mute tracing on cleanup, instead of waiting for a cleanup span. This test is flaky when it does not receive the cleanup span in time (under heavy load). Also, do not shallow exceptions on cleanup. If we ever get them, we can address them, or add a more specific catch.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~a049705733, baseline=1.40.0-SNAPSHOT~04db2f0bfb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.082 s) : 0, 1081732
Total [baseline] (8.589 s) : 0, 8589251
Agent [candidate] (1.082 s) : 0, 1081569
Total [candidate] (8.571 s) : 0, 8570687
section iast
Agent [baseline] (1.191 s) : 0, 1191187
Total [baseline] (8.991 s) : 0, 8991312
Agent [candidate] (1.19 s) : 0, 1190415
Total [candidate] (8.998 s) : 0, 8998270
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.193 s) : 0, 1192810
Total [baseline] (8.965 s) : 0, 8965112
Agent [candidate] (1.191 s) : 0, 1190976
Total [candidate] (8.973 s) : 0, 8972588
section iast_TELEMETRY_OFF
Agent [baseline] (1.187 s) : 0, 1187488
Total [baseline] (8.97 s) : 0, 8969874
Agent [candidate] (1.189 s) : 0, 1188750
Total [candidate] (8.972 s) : 0, 8972195
gantt
title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~a049705733, baseline=1.40.0-SNAPSHOT~04db2f0bfb
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (691.569 ms) : 0, 691569
BytebuddyAgent [candidate] (690.715 ms) : 0, 690715
GlobalTracer [baseline] (315.209 ms) : 0, 315209
GlobalTracer [candidate] (315.774 ms) : 0, 315774
AppSec [baseline] (52.54 ms) : 0, 52540
AppSec [candidate] (52.756 ms) : 0, 52756
Remote Config [baseline] (720.582 µs) : 0, 721
Remote Config [candidate] (726.798 µs) : 0, 727
Telemetry [baseline] (7.765 ms) : 0, 7765
Telemetry [candidate] (7.652 ms) : 0, 7652
section iast
BytebuddyAgent [baseline] (792.308 ms) : 0, 792308
BytebuddyAgent [candidate] (791.928 ms) : 0, 791928
GlobalTracer [baseline] (299.493 ms) : 0, 299493
GlobalTracer [candidate] (300.13 ms) : 0, 300130
AppSec [baseline] (50.407 ms) : 0, 50407
AppSec [candidate] (53.641 ms) : 0, 53641
IAST [baseline] (27.147 ms) : 0, 27147
IAST [candidate] (22.981 ms) : 0, 22981
Remote Config [baseline] (684.974 µs) : 0, 685
Remote Config [candidate] (599.432 µs) : 0, 599
Telemetry [baseline] (7.363 ms) : 0, 7363
Telemetry [candidate] (7.377 ms) : 0, 7377
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (793.451 ms) : 0, 793451
BytebuddyAgent [candidate] (792.56 ms) : 0, 792560
GlobalTracer [baseline] (300.247 ms) : 0, 300247
GlobalTracer [candidate] (299.769 ms) : 0, 299769
AppSec [baseline] (53.533 ms) : 0, 53533
AppSec [candidate] (54.257 ms) : 0, 54257
IAST [baseline] (22.953 ms) : 0, 22953
IAST [candidate] (22.712 ms) : 0, 22712
Remote Config [baseline] (629.161 µs) : 0, 629
Remote Config [candidate] (607.321 µs) : 0, 607
Telemetry [baseline] (8.13 ms) : 0, 8130
Telemetry [candidate] (7.318 ms) : 0, 7318
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (788.932 ms) : 0, 788932
BytebuddyAgent [candidate] (790.058 ms) : 0, 790058
GlobalTracer [baseline] (300.009 ms) : 0, 300009
GlobalTracer [candidate] (300.121 ms) : 0, 300121
AppSec [baseline] (56.852 ms) : 0, 56852
AppSec [candidate] (54.465 ms) : 0, 54465
IAST [baseline] (19.963 ms) : 0, 19963
IAST [candidate] (22.451 ms) : 0, 22451
Remote Config [baseline] (605.675 µs) : 0, 606
Remote Config [candidate] (599.197 µs) : 0, 599
Telemetry [baseline] (7.358 ms) : 0, 7358
Telemetry [candidate] (7.258 ms) : 0, 7258
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~a049705733, baseline=1.40.0-SNAPSHOT~04db2f0bfb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1066387
Total [baseline] (10.389 s) : 0, 10389285
Agent [candidate] (1.074 s) : 0, 1074412
Total [candidate] (10.372 s) : 0, 10371813
section appsec
Agent [baseline] (1.203 s) : 0, 1202659
Total [baseline] (10.613 s) : 0, 10612679
Agent [candidate] (1.202 s) : 0, 1202354
Total [candidate] (10.64 s) : 0, 10640330
section iast
Agent [baseline] (1.201 s) : 0, 1200556
Total [baseline] (10.846 s) : 0, 10845676
Agent [candidate] (1.196 s) : 0, 1195585
Total [candidate] (10.856 s) : 0, 10855980
section profiling
Agent [baseline] (1.275 s) : 0, 1274530
Total [baseline] (10.749 s) : 0, 10748936
Agent [candidate] (1.273 s) : 0, 1273051
Total [candidate] (10.739 s) : 0, 10738762
gantt
title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~a049705733, baseline=1.40.0-SNAPSHOT~04db2f0bfb
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.084 ms) : 0, 681084
BytebuddyAgent [candidate] (686.145 ms) : 0, 686145
GlobalTracer [baseline] (311.441 ms) : 0, 311441
GlobalTracer [candidate] (313.834 ms) : 0, 313834
AppSec [baseline] (51.811 ms) : 0, 51811
AppSec [candidate] (52.263 ms) : 0, 52263
Remote Config [baseline] (707.328 µs) : 0, 707
Remote Config [candidate] (721.889 µs) : 0, 722
Telemetry [baseline] (7.632 ms) : 0, 7632
Telemetry [candidate] (7.597 ms) : 0, 7597
section appsec
BytebuddyAgent [baseline] (703.507 ms) : 0, 703507
BytebuddyAgent [candidate] (702.337 ms) : 0, 702337
GlobalTracer [baseline] (304.789 ms) : 0, 304789
GlobalTracer [candidate] (305.141 ms) : 0, 305141
AppSec [baseline] (160.904 ms) : 0, 160904
AppSec [candidate] (161.619 ms) : 0, 161619
IAST [baseline] (18.589 ms) : 0, 18589
IAST [candidate] (20.072 ms) : 0, 20072
Remote Config [baseline] (652.119 µs) : 0, 652
Remote Config [candidate] (650.186 µs) : 0, 650
Telemetry [baseline] (9.722 ms) : 0, 9722
Telemetry [candidate] (8.795 ms) : 0, 8795
section iast
BytebuddyAgent [baseline] (799.488 ms) : 0, 799488
BytebuddyAgent [candidate] (795.426 ms) : 0, 795426
GlobalTracer [baseline] (301.93 ms) : 0, 301930
GlobalTracer [candidate] (301.057 ms) : 0, 301057
AppSec [baseline] (53.547 ms) : 0, 53547
AppSec [candidate] (53.591 ms) : 0, 53591
IAST [baseline] (23.814 ms) : 0, 23814
IAST [candidate] (23.707 ms) : 0, 23707
Remote Config [baseline] (624.007 µs) : 0, 624
Remote Config [candidate] (620.689 µs) : 0, 621
Telemetry [baseline] (7.32 ms) : 0, 7320
Telemetry [candidate] (7.398 ms) : 0, 7398
section profiling
BytebuddyAgent [baseline] (680.521 ms) : 0, 680521
BytebuddyAgent [candidate] (680.027 ms) : 0, 680027
GlobalTracer [baseline] (396.579 ms) : 0, 396579
GlobalTracer [candidate] (395.988 ms) : 0, 395988
AppSec [baseline] (53.093 ms) : 0, 53093
AppSec [candidate] (52.758 ms) : 0, 52758
Remote Config [baseline] (725.474 µs) : 0, 725
Remote Config [candidate] (707.72 µs) : 0, 708
Telemetry [baseline] (7.487 ms) : 0, 7487
Telemetry [candidate] (7.475 ms) : 0, 7475
ProfilingAgent [baseline] (97.62 ms) : 0, 97620
ProfilingAgent [candidate] (97.564 ms) : 0, 97564
Profiling [baseline] (97.644 ms) : 0, 97644
Profiling [candidate] (97.588 ms) : 0, 97588
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~a049705733, baseline=1.40.0-SNAPSHOT~04db2f0bfb
dateFormat X
axisFormat %s
section baseline
no_agent (1.365 ms) : 1345, 1386
. : milestone, 1365,
appsec (1.709 ms) : 1684, 1734
. : milestone, 1709,
appsec_no_iast (1.75 ms) : 1726, 1775
. : milestone, 1750,
iast (1.475 ms) : 1453, 1497
. : milestone, 1475,
profiling (1.489 ms) : 1464, 1514
. : milestone, 1489,
tracing (1.495 ms) : 1471, 1519
. : milestone, 1495,
section candidate
no_agent (1.333 ms) : 1314, 1353
. : milestone, 1333,
appsec (1.73 ms) : 1705, 1754
. : milestone, 1730,
appsec_no_iast (1.728 ms) : 1703, 1752
. : milestone, 1728,
iast (1.481 ms) : 1459, 1503
. : milestone, 1481,
profiling (1.487 ms) : 1463, 1510
. : milestone, 1487,
tracing (1.478 ms) : 1454, 1502
. : milestone, 1478,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~a049705733, baseline=1.40.0-SNAPSHOT~04db2f0bfb
dateFormat X
axisFormat %s
section baseline
no_agent (375.341 µs) : 355, 395
. : milestone, 375,
iast (495.418 µs) : 473, 518
. : milestone, 495,
iast_FULL (559.73 µs) : 538, 581
. : milestone, 560,
iast_GLOBAL (520.966 µs) : 499, 543
. : milestone, 521,
iast_HARDCODED_SECRET_DISABLED (496.697 µs) : 475, 519
. : milestone, 497,
iast_INACTIVE (450.041 µs) : 430, 471
. : milestone, 450,
iast_TELEMETRY_OFF (494.053 µs) : 471, 518
. : milestone, 494,
tracing (455.462 µs) : 435, 476
. : milestone, 455,
section candidate
no_agent (378.123 µs) : 358, 398
. : milestone, 378,
iast (493.173 µs) : 471, 516
. : milestone, 493,
iast_FULL (559.204 µs) : 538, 580
. : milestone, 559,
iast_GLOBAL (506.406 µs) : 486, 527
. : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (493.773 µs) : 472, 516
. : milestone, 494,
iast_INACTIVE (456.705 µs) : 436, 478
. : milestone, 457,
iast_TELEMETRY_OFF (482.174 µs) : 459, 505
. : milestone, 482,
tracing (452.607 µs) : 432, 474
. : milestone, 453,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~a049705733, baseline=1.40.0-SNAPSHOT~04db2f0bfb
dateFormat X
axisFormat %s
section baseline
no_agent (15.321 s) : 15321000, 15321000
. : milestone, 15321000,
appsec (15.209 s) : 15209000, 15209000
. : milestone, 15209000,
iast (18.861 s) : 18861000, 18861000
. : milestone, 18861000,
iast_GLOBAL (17.989 s) : 17989000, 17989000
. : milestone, 17989000,
profiling (14.9 s) : 14900000, 14900000
. : milestone, 14900000,
tracing (15.41 s) : 15410000, 15410000
. : milestone, 15410000,
section candidate
no_agent (14.898 s) : 14898000, 14898000
. : milestone, 14898000,
appsec (15.372 s) : 15372000, 15372000
. : milestone, 15372000,
iast (18.933 s) : 18933000, 18933000
. : milestone, 18933000,
iast_GLOBAL (18.09 s) : 18090000, 18090000
. : milestone, 18090000,
profiling (14.876 s) : 14876000, 14876000
. : milestone, 14876000,
tracing (15.162 s) : 15162000, 15162000
. : milestone, 15162000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~a049705733, baseline=1.40.0-SNAPSHOT~04db2f0bfb
dateFormat X
axisFormat %s
section baseline
no_agent (1.457 ms) : 1446, 1469
. : milestone, 1457,
appsec (2.278 ms) : 2238, 2319
. : milestone, 2278,
iast (2.023 ms) : 1974, 2071
. : milestone, 2023,
iast_GLOBAL (2.078 ms) : 2028, 2128
. : milestone, 2078,
profiling (1.91 ms) : 1871, 1950
. : milestone, 1910,
tracing (1.883 ms) : 1845, 1921
. : milestone, 1883,
section candidate
no_agent (1.465 ms) : 1454, 1477
. : milestone, 1465,
appsec (2.279 ms) : 2239, 2319
. : milestone, 2279,
iast (2.042 ms) : 1992, 2092
. : milestone, 2042,
iast_GLOBAL (2.08 ms) : 2030, 2130
. : milestone, 2080,
profiling (1.917 ms) : 1877, 1956
. : milestone, 1917,
tracing (1.883 ms) : 1845, 1921
. : milestone, 1883,
|
amarziali
approved these changes
Sep 11, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: testing
Testing
tag: flaky test
Flaky tests
tag: no release notes
Changes to exclude from release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Mute tracing on cleanup, instead of waiting for a cleanup span. This test is flaky when it does not receive the cleanup span in time (under heavy load).
Also, do not shallow exceptions on cleanup. If we ever get them, we can address them, or add a more specific catch.
Motivation
Additional Notes
Trick copied from @amarziali at #7597
The same pattern could be used in quite a few more (potentially flaky) tests.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issue[ ] Update the public documentation in case of new configuration flag or behavior