-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add profiling scenario to onboarding tests #7601
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~5b6fac57a5, baseline=1.40.0-SNAPSHOT~aae44c777e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.073 s) : 0, 1073345
Total [baseline] (10.478 s) : 0, 10477571
Agent [candidate] (1.075 s) : 0, 1075378
Total [candidate] (10.407 s) : 0, 10407340
section appsec
Agent [baseline] (1.203 s) : 0, 1203343
Total [baseline] (10.611 s) : 0, 10611096
Agent [candidate] (1.205 s) : 0, 1204557
Total [candidate] (10.629 s) : 0, 10629167
section iast
Agent [baseline] (1.195 s) : 0, 1194708
Total [baseline] (10.915 s) : 0, 10914862
Agent [candidate] (1.196 s) : 0, 1195669
Total [candidate] (10.834 s) : 0, 10834252
section profiling
Agent [baseline] (1.267 s) : 0, 1267331
Total [baseline] (10.576 s) : 0, 10575758
Agent [candidate] (1.275 s) : 0, 1275129
Total [candidate] (10.593 s) : 0, 10592738
gantt
title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~5b6fac57a5, baseline=1.40.0-SNAPSHOT~aae44c777e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.225 ms) : 0, 685225
BytebuddyAgent [candidate] (687.497 ms) : 0, 687497
GlobalTracer [baseline] (313.487 ms) : 0, 313487
GlobalTracer [candidate] (313.552 ms) : 0, 313552
AppSec [baseline] (52.329 ms) : 0, 52329
AppSec [candidate] (52.113 ms) : 0, 52113
Remote Config [baseline] (713.931 µs) : 0, 714
Remote Config [candidate] (713.023 µs) : 0, 713
Telemetry [baseline] (7.717 ms) : 0, 7717
Telemetry [candidate] (7.565 ms) : 0, 7565
section appsec
BytebuddyAgent [baseline] (702.98 ms) : 0, 702980
BytebuddyAgent [candidate] (703.475 ms) : 0, 703475
GlobalTracer [baseline] (305.498 ms) : 0, 305498
GlobalTracer [candidate] (306.202 ms) : 0, 306202
AppSec [baseline] (160.975 ms) : 0, 160975
AppSec [candidate] (162.473 ms) : 0, 162473
IAST [baseline] (20.862 ms) : 0, 20862
IAST [candidate] (19.879 ms) : 0, 19879
Remote Config [baseline] (655.103 µs) : 0, 655
Remote Config [candidate] (650.557 µs) : 0, 651
Telemetry [baseline] (9.025 ms) : 0, 9025
Telemetry [candidate] (8.028 ms) : 0, 8028
section iast
BytebuddyAgent [baseline] (794.569 ms) : 0, 794569
BytebuddyAgent [candidate] (794.77 ms) : 0, 794770
GlobalTracer [baseline] (301.448 ms) : 0, 301448
GlobalTracer [candidate] (302.057 ms) : 0, 302057
AppSec [baseline] (54.028 ms) : 0, 54028
AppSec [candidate] (53.291 ms) : 0, 53291
IAST [baseline] (22.85 ms) : 0, 22850
IAST [candidate] (22.987 ms) : 0, 22987
Remote Config [baseline] (629.947 µs) : 0, 630
Remote Config [candidate] (606.784 µs) : 0, 607
Telemetry [baseline] (7.408 ms) : 0, 7408
Telemetry [candidate] (8.167 ms) : 0, 8167
section profiling
BytebuddyAgent [baseline] (675.536 ms) : 0, 675536
BytebuddyAgent [candidate] (680.972 ms) : 0, 680972
GlobalTracer [baseline] (396.402 ms) : 0, 396402
GlobalTracer [candidate] (397.348 ms) : 0, 397348
AppSec [baseline] (52.515 ms) : 0, 52515
AppSec [candidate] (52.91 ms) : 0, 52910
Remote Config [baseline] (697.238 µs) : 0, 697
Remote Config [candidate] (721.348 µs) : 0, 721
Telemetry [baseline] (7.402 ms) : 0, 7402
Telemetry [candidate] (7.587 ms) : 0, 7587
ProfilingAgent [baseline] (96.373 ms) : 0, 96373
ProfilingAgent [candidate] (96.994 ms) : 0, 96994
Profiling [baseline] (96.397 ms) : 0, 96397
Profiling [candidate] (97.018 ms) : 0, 97018
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~5b6fac57a5, baseline=1.40.0-SNAPSHOT~aae44c777e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1069337
Total [baseline] (8.552 s) : 0, 8551577
Agent [candidate] (1.068 s) : 0, 1067935
Total [candidate] (8.555 s) : 0, 8555344
section iast
Agent [baseline] (1.194 s) : 0, 1193531
Total [baseline] (8.991 s) : 0, 8990992
Agent [candidate] (1.191 s) : 0, 1190777
Total [candidate] (9.0 s) : 0, 9000039
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.193 s) : 0, 1192749
Total [baseline] (9.005 s) : 0, 9004608
Agent [candidate] (1.196 s) : 0, 1195880
Total [candidate] (8.978 s) : 0, 8977910
section iast_TELEMETRY_OFF
Agent [baseline] (1.189 s) : 0, 1189354
Total [baseline] (8.988 s) : 0, 8988123
Agent [candidate] (1.191 s) : 0, 1191039
Total [candidate] (9.027 s) : 0, 9026762
gantt
title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~5b6fac57a5, baseline=1.40.0-SNAPSHOT~aae44c777e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.708 ms) : 0, 682708
BytebuddyAgent [candidate] (681.427 ms) : 0, 681427
GlobalTracer [baseline] (312.816 ms) : 0, 312816
GlobalTracer [candidate] (312.53 ms) : 0, 312530
AppSec [baseline] (51.741 ms) : 0, 51741
AppSec [candidate] (51.929 ms) : 0, 51929
Remote Config [baseline] (744.483 µs) : 0, 744
Remote Config [candidate] (725.708 µs) : 0, 726
Telemetry [baseline] (7.573 ms) : 0, 7573
Telemetry [candidate] (7.553 ms) : 0, 7553
section iast
BytebuddyAgent [baseline] (794.577 ms) : 0, 794577
BytebuddyAgent [candidate] (791.843 ms) : 0, 791843
GlobalTracer [baseline] (300.105 ms) : 0, 300105
GlobalTracer [candidate] (300.393 ms) : 0, 300393
AppSec [baseline] (51.646 ms) : 0, 51646
AppSec [candidate] (53.971 ms) : 0, 53971
IAST [baseline] (25.42 ms) : 0, 25420
IAST [candidate] (21.195 ms) : 0, 21195
Remote Config [baseline] (620.592 µs) : 0, 621
Remote Config [candidate] (2.152 ms) : 0, 2152
Telemetry [baseline] (7.324 ms) : 0, 7324
Telemetry [candidate] (7.439 ms) : 0, 7439
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (793.161 ms) : 0, 793161
BytebuddyAgent [candidate] (795.152 ms) : 0, 795152
GlobalTracer [baseline] (300.783 ms) : 0, 300783
GlobalTracer [candidate] (301.308 ms) : 0, 301308
AppSec [baseline] (54.267 ms) : 0, 54267
AppSec [candidate] (53.755 ms) : 0, 53755
IAST [baseline] (22.741 ms) : 0, 22741
IAST [candidate] (23.776 ms) : 0, 23776
Remote Config [baseline] (609.878 µs) : 0, 610
Remote Config [candidate] (613.404 µs) : 0, 613
Telemetry [baseline] (7.373 ms) : 0, 7373
Telemetry [candidate] (7.403 ms) : 0, 7403
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (790.126 ms) : 0, 790126
BytebuddyAgent [candidate] (790.955 ms) : 0, 790955
GlobalTracer [baseline] (300.758 ms) : 0, 300758
GlobalTracer [candidate] (301.295 ms) : 0, 301295
AppSec [baseline] (54.192 ms) : 0, 54192
AppSec [candidate] (56.16 ms) : 0, 56160
IAST [baseline] (21.003 ms) : 0, 21003
IAST [candidate] (19.998 ms) : 0, 19998
Remote Config [baseline] (624.344 µs) : 0, 624
Remote Config [candidate] (610.458 µs) : 0, 610
Telemetry [baseline] (8.854 ms) : 0, 8854
Telemetry [candidate] (8.18 ms) : 0, 8180
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~5b6fac57a5, baseline=1.40.0-SNAPSHOT~aae44c777e
dateFormat X
axisFormat %s
section baseline
no_agent (1.336 ms) : 1317, 1355
. : milestone, 1336,
appsec (1.719 ms) : 1695, 1744
. : milestone, 1719,
appsec_no_iast (1.709 ms) : 1684, 1734
. : milestone, 1709,
iast (1.488 ms) : 1464, 1512
. : milestone, 1488,
profiling (1.484 ms) : 1460, 1508
. : milestone, 1484,
tracing (1.474 ms) : 1450, 1499
. : milestone, 1474,
section candidate
no_agent (1.343 ms) : 1324, 1363
. : milestone, 1343,
appsec (1.712 ms) : 1688, 1737
. : milestone, 1712,
appsec_no_iast (1.757 ms) : 1732, 1781
. : milestone, 1757,
iast (1.511 ms) : 1488, 1534
. : milestone, 1511,
profiling (1.559 ms) : 1533, 1585
. : milestone, 1559,
tracing (1.475 ms) : 1451, 1500
. : milestone, 1475,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~5b6fac57a5, baseline=1.40.0-SNAPSHOT~aae44c777e
dateFormat X
axisFormat %s
section baseline
no_agent (372.485 µs) : 353, 392
. : milestone, 372,
iast (481.654 µs) : 460, 504
. : milestone, 482,
iast_FULL (557.004 µs) : 536, 578
. : milestone, 557,
iast_GLOBAL (519.253 µs) : 497, 541
. : milestone, 519,
iast_HARDCODED_SECRET_DISABLED (496.442 µs) : 475, 518
. : milestone, 496,
iast_INACTIVE (446.409 µs) : 426, 467
. : milestone, 446,
iast_TELEMETRY_OFF (481.298 µs) : 458, 504
. : milestone, 481,
tracing (444.903 µs) : 424, 466
. : milestone, 445,
section candidate
no_agent (376.976 µs) : 357, 397
. : milestone, 377,
iast (486.462 µs) : 465, 508
. : milestone, 486,
iast_FULL (560.541 µs) : 539, 582
. : milestone, 561,
iast_GLOBAL (522.269 µs) : 499, 546
. : milestone, 522,
iast_HARDCODED_SECRET_DISABLED (486.809 µs) : 465, 509
. : milestone, 487,
iast_INACTIVE (448.539 µs) : 428, 469
. : milestone, 449,
iast_TELEMETRY_OFF (472.483 µs) : 450, 495
. : milestone, 472,
tracing (443.416 µs) : 423, 464
. : milestone, 443,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~5b6fac57a5, baseline=1.40.0-SNAPSHOT~aae44c777e
dateFormat X
axisFormat %s
section baseline
no_agent (1.458 ms) : 1447, 1469
. : milestone, 1458,
appsec (2.276 ms) : 2236, 2317
. : milestone, 2276,
iast (2.037 ms) : 1987, 2086
. : milestone, 2037,
iast_GLOBAL (2.09 ms) : 2039, 2140
. : milestone, 2090,
profiling (1.913 ms) : 1872, 1955
. : milestone, 1913,
tracing (1.885 ms) : 1847, 1923
. : milestone, 1885,
section candidate
no_agent (1.459 ms) : 1447, 1470
. : milestone, 1459,
appsec (2.284 ms) : 2243, 2324
. : milestone, 2284,
iast (2.031 ms) : 1983, 2079
. : milestone, 2031,
iast_GLOBAL (2.084 ms) : 2034, 2134
. : milestone, 2084,
profiling (1.913 ms) : 1874, 1952
. : milestone, 1913,
tracing (1.899 ms) : 1860, 1937
. : milestone, 1899,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~5b6fac57a5, baseline=1.40.0-SNAPSHOT~aae44c777e
dateFormat X
axisFormat %s
section baseline
no_agent (15.732 s) : 15732000, 15732000
. : milestone, 15732000,
appsec (15.272 s) : 15272000, 15272000
. : milestone, 15272000,
iast (19.006 s) : 19006000, 19006000
. : milestone, 19006000,
iast_GLOBAL (18.064 s) : 18064000, 18064000
. : milestone, 18064000,
profiling (15.282 s) : 15282000, 15282000
. : milestone, 15282000,
tracing (15.235 s) : 15235000, 15235000
. : milestone, 15235000,
section candidate
no_agent (15.07 s) : 15070000, 15070000
. : milestone, 15070000,
appsec (15.326 s) : 15326000, 15326000
. : milestone, 15326000,
iast (18.699 s) : 18699000, 18699000
. : milestone, 18699000,
iast_GLOBAL (18.102 s) : 18102000, 18102000
. : milestone, 18102000,
profiling (15.43 s) : 15430000, 15430000
. : milestone, 15430000,
tracing (15.32 s) : 15320000, 15320000
. : milestone, 15320000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What Does This Do
Adds a profiling scenario to the onboarding tests. You can see it in action as it now ran in the Gitlab checks in this PR!
Motivation
Profiler now supports SSI, so adding a test for it in the test matrix here ensures we quickly notice if it gets broken.
Additional Notes
The
test-app-java-buildpack
weblog is excluded for now, as it is known to fail due to unrelated reasons in system-tests build.Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: PROF-10521