Disable data streams http & grpc instrumentations by default #7839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 10 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~c282bd7660, baseline=1.43.0-SNAPSHOT~8233fc5ff8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1083925
Total [baseline] (10.408 s) : 0, 10408233
Agent [candidate] (1.083 s) : 0, 1082660
Total [candidate] (10.411 s) : 0, 10410721
section appsec
Agent [baseline] (1.22 s) : 0, 1219619
Total [baseline] (10.671 s) : 0, 10671376
Agent [candidate] (1.217 s) : 0, 1217353
Total [candidate] (10.689 s) : 0, 10689201
section iast
Agent [baseline] (1.221 s) : 0, 1220529
Total [baseline] (10.887 s) : 0, 10887023
Agent [candidate] (1.218 s) : 0, 1218392
Total [candidate] (10.936 s) : 0, 10936095
section profiling
Agent [baseline] (1.282 s) : 0, 1282202
Total [baseline] (10.843 s) : 0, 10842906
Agent [candidate] (1.28 s) : 0, 1280412
Total [candidate] (10.728 s) : 0, 10727517
gantt
title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~c282bd7660, baseline=1.43.0-SNAPSHOT~8233fc5ff8
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.406 ms) : 0, 688406
BytebuddyAgent [candidate] (687.348 ms) : 0, 687348
GlobalTracer [baseline] (317.514 ms) : 0, 317514
GlobalTracer [candidate] (316.644 ms) : 0, 316644
AppSec [baseline] (54.36 ms) : 0, 54360
AppSec [candidate] (54.198 ms) : 0, 54198
Remote Config [baseline] (682.302 µs) : 0, 682
Remote Config [candidate] (670.484 µs) : 0, 670
Telemetry [baseline] (9.172 ms) : 0, 9172
Telemetry [candidate] (10.028 ms) : 0, 10028
section appsec
BytebuddyAgent [baseline] (705.36 ms) : 0, 705360
BytebuddyAgent [candidate] (704.921 ms) : 0, 704921
GlobalTracer [baseline] (314.756 ms) : 0, 314756
GlobalTracer [candidate] (314.075 ms) : 0, 314075
AppSec [baseline] (167.779 ms) : 0, 167779
AppSec [candidate] (166.526 ms) : 0, 166526
Remote Config [baseline] (643.423 µs) : 0, 643
Remote Config [candidate] (638.565 µs) : 0, 639
Telemetry [baseline] (7.469 ms) : 0, 7469
Telemetry [candidate] (8.146 ms) : 0, 8146
IAST [baseline] (19.732 ms) : 0, 19732
IAST [candidate] (18.544 ms) : 0, 18544
section iast
BytebuddyAgent [baseline] (811.689 ms) : 0, 811689
BytebuddyAgent [candidate] (810.609 ms) : 0, 810609
GlobalTracer [baseline] (307.694 ms) : 0, 307694
GlobalTracer [candidate] (307.304 ms) : 0, 307304
AppSec [baseline] (57.137 ms) : 0, 57137
AppSec [candidate] (57.755 ms) : 0, 57755
Remote Config [baseline] (625.636 µs) : 0, 626
Remote Config [candidate] (630.992 µs) : 0, 631
Telemetry [baseline] (7.621 ms) : 0, 7621
Telemetry [candidate] (7.588 ms) : 0, 7588
IAST [baseline] (21.865 ms) : 0, 21865
IAST [candidate] (20.568 ms) : 0, 20568
section profiling
ProfilingAgent [baseline] (96.089 ms) : 0, 96089
ProfilingAgent [candidate] (89.227 ms) : 0, 89227
BytebuddyAgent [baseline] (683.427 ms) : 0, 683427
BytebuddyAgent [candidate] (682.278 ms) : 0, 682278
GlobalTracer [baseline] (399.736 ms) : 0, 399736
GlobalTracer [candidate] (400.009 ms) : 0, 400009
AppSec [baseline] (54.605 ms) : 0, 54605
AppSec [candidate] (54.54 ms) : 0, 54540
Remote Config [baseline] (683.467 µs) : 0, 683
Remote Config [candidate] (678.331 µs) : 0, 678
Telemetry [baseline] (8.624 ms) : 0, 8624
Telemetry [candidate] (14.779 ms) : 0, 14779
Profiling [baseline] (96.112 ms) : 0, 96112
Profiling [candidate] (89.251 ms) : 0, 89251
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~c282bd7660, baseline=1.43.0-SNAPSHOT~8233fc5ff8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1085961
Total [baseline] (8.593 s) : 0, 8592970
Agent [candidate] (1.088 s) : 0, 1087819
Total [candidate] (8.582 s) : 0, 8581896
section iast
Agent [baseline] (1.233 s) : 0, 1232787
Total [baseline] (9.166 s) : 0, 9166071
Agent [candidate] (1.211 s) : 0, 1210806
Total [candidate] (9.093 s) : 0, 9092620
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.213 s) : 0, 1212896
Total [baseline] (9.119 s) : 0, 9118694
Agent [candidate] (1.209 s) : 0, 1208958
Total [candidate] (9.092 s) : 0, 9091688
section iast_TELEMETRY_OFF
Agent [baseline] (1.217 s) : 0, 1216868
Total [baseline] (9.191 s) : 0, 9191171
Agent [candidate] (1.205 s) : 0, 1204640
Total [candidate] (9.099 s) : 0, 9099001
gantt
title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~c282bd7660, baseline=1.43.0-SNAPSHOT~8233fc5ff8
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.111 ms) : 0, 689111
BytebuddyAgent [candidate] (689.292 ms) : 0, 689292
GlobalTracer [baseline] (317.372 ms) : 0, 317372
GlobalTracer [candidate] (316.927 ms) : 0, 316927
AppSec [baseline] (54.466 ms) : 0, 54466
AppSec [candidate] (54.267 ms) : 0, 54267
Remote Config [baseline] (671.665 µs) : 0, 672
Remote Config [candidate] (678.647 µs) : 0, 679
Telemetry [baseline] (10.524 ms) : 0, 10524
Telemetry [candidate] (12.815 ms) : 0, 12815
section iast
BytebuddyAgent [baseline] (820.961 ms) : 0, 820961
BytebuddyAgent [candidate] (805.817 ms) : 0, 805817
GlobalTracer [baseline] (310.624 ms) : 0, 310624
GlobalTracer [candidate] (305.718 ms) : 0, 305718
AppSec [baseline] (57.386 ms) : 0, 57386
AppSec [candidate] (56.537 ms) : 0, 56537
IAST [baseline] (21.588 ms) : 0, 21588
IAST [candidate] (20.809 ms) : 0, 20809
Remote Config [baseline] (616.745 µs) : 0, 617
Remote Config [candidate] (605.102 µs) : 0, 605
Telemetry [baseline] (7.571 ms) : 0, 7571
Telemetry [candidate] (7.43 ms) : 0, 7430
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (806.335 ms) : 0, 806335
BytebuddyAgent [candidate] (803.812 ms) : 0, 803812
GlobalTracer [baseline] (306.242 ms) : 0, 306242
GlobalTracer [candidate] (305.608 ms) : 0, 305608
AppSec [baseline] (56.754 ms) : 0, 56754
AppSec [candidate] (56.68 ms) : 0, 56680
IAST [baseline] (21.543 ms) : 0, 21543
IAST [candidate] (20.89 ms) : 0, 20890
Remote Config [baseline] (643.937 µs) : 0, 644
Remote Config [candidate] (616.218 µs) : 0, 616
Telemetry [baseline] (7.525 ms) : 0, 7525
Telemetry [candidate] (7.532 ms) : 0, 7532
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (807.269 ms) : 0, 807269
BytebuddyAgent [candidate] (800.224 ms) : 0, 800224
GlobalTracer [baseline] (307.654 ms) : 0, 307654
GlobalTracer [candidate] (304.793 ms) : 0, 304793
AppSec [baseline] (56.696 ms) : 0, 56696
AppSec [candidate] (57.442 ms) : 0, 57442
IAST [baseline] (23.117 ms) : 0, 23117
IAST [candidate] (20.364 ms) : 0, 20364
Remote Config [baseline] (623.922 µs) : 0, 624
Remote Config [candidate] (609.038 µs) : 0, 609
Telemetry [baseline] (7.61 ms) : 0, 7610
Telemetry [candidate] (7.38 ms) : 0, 7380
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~c282bd7660, baseline=1.43.0-SNAPSHOT~8233fc5ff8
dateFormat X
axisFormat %s
section baseline
no_agent (1.327 ms) : 1307, 1347
. : milestone, 1327,
appsec (1.73 ms) : 1707, 1753
. : milestone, 1730,
appsec_no_iast (1.71 ms) : 1685, 1734
. : milestone, 1710,
iast (1.466 ms) : 1443, 1489
. : milestone, 1466,
profiling (1.522 ms) : 1498, 1546
. : milestone, 1522,
tracing (1.453 ms) : 1429, 1477
. : milestone, 1453,
section candidate
no_agent (1.331 ms) : 1311, 1350
. : milestone, 1331,
appsec (1.723 ms) : 1699, 1747
. : milestone, 1723,
appsec_no_iast (1.716 ms) : 1692, 1740
. : milestone, 1716,
iast (1.482 ms) : 1459, 1504
. : milestone, 1482,
profiling (1.503 ms) : 1479, 1528
. : milestone, 1503,
tracing (1.484 ms) : 1460, 1507
. : milestone, 1484,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~c282bd7660, baseline=1.43.0-SNAPSHOT~8233fc5ff8
dateFormat X
axisFormat %s
section baseline
no_agent (363.205 µs) : 343, 383
. : milestone, 363,
iast (485.071 µs) : 464, 506
. : milestone, 485,
iast_FULL (639.854 µs) : 618, 661
. : milestone, 640,
iast_GLOBAL (503.577 µs) : 482, 525
. : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (484.686 µs) : 463, 506
. : milestone, 485,
iast_INACTIVE (461.591 µs) : 440, 483
. : milestone, 462,
iast_TELEMETRY_OFF (474.348 µs) : 453, 496
. : milestone, 474,
tracing (438.67 µs) : 418, 459
. : milestone, 439,
section candidate
no_agent (369.814 µs) : 350, 389
. : milestone, 370,
iast (478.029 µs) : 457, 499
. : milestone, 478,
iast_FULL (635.181 µs) : 613, 657
. : milestone, 635,
iast_GLOBAL (508.744 µs) : 487, 531
. : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (477.679 µs) : 456, 499
. : milestone, 478,
iast_INACTIVE (445.953 µs) : 425, 467
. : milestone, 446,
iast_TELEMETRY_OFF (470.533 µs) : 449, 492
. : milestone, 471,
tracing (444.049 µs) : 423, 465
. : milestone, 444,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~c282bd7660, baseline=1.43.0-SNAPSHOT~8233fc5ff8
dateFormat X
axisFormat %s
section baseline
no_agent (1.463 ms) : 1452, 1475
. : milestone, 1463,
appsec (2.331 ms) : 2290, 2372
. : milestone, 2331,
iast (2.068 ms) : 2017, 2120
. : milestone, 2068,
iast_GLOBAL (2.114 ms) : 2063, 2166
. : milestone, 2114,
profiling (1.936 ms) : 1895, 1977
. : milestone, 1936,
tracing (1.912 ms) : 1872, 1952
. : milestone, 1912,
section candidate
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.339 ms) : 2298, 2380
. : milestone, 2339,
iast (2.07 ms) : 2019, 2122
. : milestone, 2070,
iast_GLOBAL (2.126 ms) : 2073, 2179
. : milestone, 2126,
profiling (1.943 ms) : 1900, 1985
. : milestone, 1943,
tracing (1.921 ms) : 1880, 1961
. : milestone, 1921,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~c282bd7660, baseline=1.43.0-SNAPSHOT~8233fc5ff8
dateFormat X
axisFormat %s
section baseline
no_agent (15.169 s) : 15169000, 15169000
. : milestone, 15169000,
appsec (15.256 s) : 15256000, 15256000
. : milestone, 15256000,
iast (19.166 s) : 19166000, 19166000
. : milestone, 19166000,
iast_GLOBAL (18.128 s) : 18128000, 18128000
. : milestone, 18128000,
profiling (15.488 s) : 15488000, 15488000
. : milestone, 15488000,
tracing (15.134 s) : 15134000, 15134000
. : milestone, 15134000,
section candidate
no_agent (15.586 s) : 15586000, 15586000
. : milestone, 15586000,
appsec (16.24 s) : 16240000, 16240000
. : milestone, 16240000,
iast (18.868 s) : 18868000, 18868000
. : milestone, 18868000,
iast_GLOBAL (17.916 s) : 17916000, 17916000
. : milestone, 17916000,
profiling (15.164 s) : 15164000, 15164000
. : milestone, 15164000,
tracing (15.125 s) : 15125000, 15125000
. : milestone, 15125000,
|
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| testRuntimeOnly project(':dd-java-agent:instrumentation:java-io') | ||
| testRuntimeOnly project(':dd-java-agent:instrumentation:jackson-core') | ||
| testRuntimeOnly project(':dd-java-agent:instrumentation:jackson-core:jackson-core-2.8') | ||
| testImplementation(group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: '2.9.10') |
There was a problem hiding this comment.
⚫ Library Vulnerability
:com.fasterxml.jackson.core:jackson-databind → 2.9.10
View all suggested fixes
Suggested change
| testImplementation(group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: '2.9.10') | |
| testImplementation(group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: '2.18.0) |
Suggested change
| testImplementation(group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: '2.9.10') | |
| testImplementation(group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: '2.12.7.1) |
Suggested change
| testImplementation(group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: '2.9.10') | |
| testImplementation(group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: '2.9.10.4) |
jackson-databind mishandles the interaction between serialization gadgets and typing (...read more)
FasterXML jackson-databind 2.x before 2.9.10.4, 2.8.11.6, and 2.7.9.7 mishandles the interaction between serialization gadgets and typing, related to com.ibatis.sqlmap.engine.transaction.jta.JtaTransactionConfig (aka ibatis-sqlmap).
piochelepiotr
force-pushed
the
piotr-wolski/disable-http-grpc-dsm-tracking
branch
from
5241ca7 to
6ec04f1
Compare
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 2 metrics, 0 unstable metrics.
See unchanged results
|
|
This pull request has been marked as stale because it has not had activity over the past quarter. It will be closed in 7 days if no further activity occurs. Feel free to reopen the PR if you are still working on it. |
|
This pull request has been closed because it has not had activity over the past quarter. Feel free to reopen the PR if you are still working on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
We inject data streams context for http & grpc calls by default today in Java.
This was done for a few customers that are using http or grpc calls to transmit data in an asynchronous way.
However, the vast majority of the time, http & grpc instrumentations are noise for monitoring data streams.
This lead us to do a lot of logic on our backend to drop the http & grpc data.
However, this still leads to an overhead for the tracer, that is not needed.
We want to enable data streams stats collection by default for all customers (to ease onboarding), so we want to minimize the overhead we are adding by doing so.
That's why this PR is putting these two integrations behind flags.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]