Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new JPA smoke test to validate the IAST visitor #7898

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Add new JPA smoke test to validate the IAST visitor #7898

merged 1 commit into from
Nov 13, 2024

Conversation

manuel-alvarez-alvarez
Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented Nov 6, 2024 •
edited
Loading

What Does This Do

Adds a new smoke test based on spring-boot and hibernate to ensure that the class com.datadog.iast.util.ObjectVisitor does not interfere with lazy lading of ORM relations triggering unwanted state changes.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@manuel-alvarez-alvarez manuel-alvarez-alvarez added type: enhancement comp: asm iast Application Security Management (IAST) labels Nov 6, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested a review from a team as a code owner November 6, 2024 11:47
@pr-commenter
Copy link

pr-commenter bot commented Nov 6, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/iast-improve-tbv-visitor
git_commit_date 1731055887 1731056157
git_commit_sha 0424969 f2a4220
release_version 1.43.0-SNAPSHOT~04249697bb 1.43.0-SNAPSHOT~f2a4220fb2
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731058609 1731058609
ci_job_id 700187938 700187938
ci_pipeline_id 48537942 48537942
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 7 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~f2a4220fb2, baseline=1.43.0-SNAPSHOT~04249697bb

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084012
Total [baseline] (10.388 s) : 0, 10387606
Agent [candidate] (1.088 s) : 0, 1088063
Total [candidate] (10.389 s) : 0, 10388559
section appsec
Agent [baseline] (1.219 s) : 0, 1218889
Total [baseline] (10.749 s) : 0, 10748805
Agent [candidate] (1.226 s) : 0, 1226417
Total [candidate] (10.683 s) : 0, 10682631
section iast
Agent [baseline] (1.217 s) : 0, 1217397
Total [baseline] (10.939 s) : 0, 10938872
Agent [candidate] (1.221 s) : 0, 1220609
Total [candidate] (10.933 s) : 0, 10932612
section profiling
Agent [baseline] (1.279 s) : 0, 1279243
Total [baseline] (10.733 s) : 0, 10732506
Agent [candidate] (1.28 s) : 0, 1279655
Total [candidate] (10.739 s) : 0, 10739299
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent appsec 1.219 s 134.876 ms (12.4%)
Agent iast 1.217 s 133.385 ms (12.3%)
Agent profiling 1.279 s 195.231 ms (18.0%)
Total tracing 10.388 s -
Total appsec 10.749 s 361.199 ms (3.5%)
Total iast 10.939 s 551.266 ms (5.3%)
Total profiling 10.733 s 344.901 ms (3.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.088 s -
Agent appsec 1.226 s 138.353 ms (12.7%)
Agent iast 1.221 s 132.546 ms (12.2%)
Agent profiling 1.28 s 191.592 ms (17.6%)
Total tracing 10.389 s -
Total appsec 10.683 s 294.072 ms (2.8%)
Total iast 10.933 s 544.053 ms (5.2%)
Total profiling 10.739 s 350.74 ms (3.4%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~f2a4220fb2, baseline=1.43.0-SNAPSHOT~04249697bb

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.286 ms) : 0, 688286
BytebuddyAgent [candidate] (693.232 ms) : 0, 693232
GlobalTracer [baseline] (316.115 ms) : 0, 316115
GlobalTracer [candidate] (316.584 ms) : 0, 316584
AppSec [baseline] (54.417 ms) : 0, 54417
AppSec [candidate] (54.518 ms) : 0, 54518
Remote Config [baseline] (679.541 µs) : 0, 680
Remote Config [candidate] (671.577 µs) : 0, 672
Telemetry [baseline] (10.761 ms) : 0, 10761
Telemetry [candidate] (9.23 ms) : 0, 9230
section appsec
BytebuddyAgent [baseline] (705.085 ms) : 0, 705085
BytebuddyAgent [candidate] (711.579 ms) : 0, 711579
GlobalTracer [baseline] (314.24 ms) : 0, 314240
GlobalTracer [candidate] (315.676 ms) : 0, 315676
AppSec [baseline] (167.691 ms) : 0, 167691
AppSec [candidate] (166.589 ms) : 0, 166589
Remote Config [baseline] (641.768 µs) : 0, 642
Remote Config [candidate] (647.757 µs) : 0, 648
Telemetry [baseline] (7.479 ms) : 0, 7479
Telemetry [candidate] (8.222 ms) : 0, 8222
IAST [baseline] (20.07 ms) : 0, 20070
IAST [candidate] (19.747 ms) : 0, 19747
section iast
BytebuddyAgent [baseline] (809.763 ms) : 0, 809763
BytebuddyAgent [candidate] (812.209 ms) : 0, 812209
GlobalTracer [baseline] (307.135 ms) : 0, 307135
GlobalTracer [candidate] (308.195 ms) : 0, 308195
AppSec [baseline] (57.878 ms) : 0, 57878
AppSec [candidate] (57.708 ms) : 0, 57708
Remote Config [baseline] (626.807 µs) : 0, 627
Remote Config [candidate] (613.814 µs) : 0, 614
Telemetry [baseline] (7.561 ms) : 0, 7561
Telemetry [candidate] (7.485 ms) : 0, 7485
IAST [baseline] (20.577 ms) : 0, 20577
IAST [candidate] (20.52 ms) : 0, 20520
section profiling
BytebuddyAgent [baseline] (682.525 ms) : 0, 682525
BytebuddyAgent [candidate] (681.362 ms) : 0, 681362
GlobalTracer [baseline] (398.851 ms) : 0, 398851
GlobalTracer [candidate] (399.18 ms) : 0, 399180
AppSec [baseline] (54.62 ms) : 0, 54620
AppSec [candidate] (55.035 ms) : 0, 55035
Remote Config [baseline] (664.4 µs) : 0, 664
Remote Config [candidate] (670.957 µs) : 0, 671
Telemetry [baseline] (10.668 ms) : 0, 10668
Telemetry [candidate] (11.357 ms) : 0, 11357
ProfilingAgent [baseline] (93.026 ms) : 0, 93026
ProfilingAgent [candidate] (93.19 ms) : 0, 93190
Profiling [baseline] (93.05 ms) : 0, 93050
Profiling [candidate] (93.213 ms) : 0, 93213
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~f2a4220fb2, baseline=1.43.0-SNAPSHOT~04249697bb

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1083070
Total [baseline] (8.574 s) : 0, 8574018
Agent [candidate] (1.092 s) : 0, 1092015
Total [candidate] (8.623 s) : 0, 8622870
section iast
Agent [baseline] (1.212 s) : 0, 1212237
Total [baseline] (9.173 s) : 0, 9173345
Agent [candidate] (1.224 s) : 0, 1224438
Total [candidate] (9.182 s) : 0, 9181644
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.215 s) : 0, 1215352
Total [baseline] (9.096 s) : 0, 9096195
Agent [candidate] (1.209 s) : 0, 1208751
Total [candidate] (9.113 s) : 0, 9112660
section iast_TELEMETRY_OFF
Agent [baseline] (1.221 s) : 0, 1221484
Total [baseline] (9.159 s) : 0, 9159124
Agent [candidate] (1.217 s) : 0, 1216770
Total [candidate] (9.121 s) : 0, 9120616
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.083 s -
Agent iast 1.212 s 129.168 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.215 s 132.283 ms (12.2%)
Agent iast_TELEMETRY_OFF 1.221 s 138.415 ms (12.8%)
Total tracing 8.574 s -
Total iast 9.173 s 599.328 ms (7.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.096 s 522.177 ms (6.1%)
Total iast_TELEMETRY_OFF 9.159 s 585.107 ms (6.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent iast 1.224 s 132.423 ms (12.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.209 s 116.735 ms (10.7%)
Agent iast_TELEMETRY_OFF 1.217 s 124.754 ms (11.4%)
Total tracing 8.623 s -
Total iast 9.182 s 558.774 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.113 s 489.79 ms (5.7%)
Total iast_TELEMETRY_OFF 9.121 s 497.746 ms (5.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~f2a4220fb2, baseline=1.43.0-SNAPSHOT~04249697bb

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.643 ms) : 0, 688643
BytebuddyAgent [candidate] (694.211 ms) : 0, 694211
GlobalTracer [baseline] (316.287 ms) : 0, 316287
GlobalTracer [candidate] (318.476 ms) : 0, 318476
AppSec [baseline] (54.431 ms) : 0, 54431
AppSec [candidate] (54.829 ms) : 0, 54829
Remote Config [baseline] (679.771 µs) : 0, 680
Remote Config [candidate] (675.178 µs) : 0, 675
Telemetry [baseline] (9.273 ms) : 0, 9273
Telemetry [candidate] (9.969 ms) : 0, 9969
section iast
BytebuddyAgent [baseline] (804.961 ms) : 0, 804961
BytebuddyAgent [candidate] (816.422 ms) : 0, 816422
GlobalTracer [baseline] (306.722 ms) : 0, 306722
GlobalTracer [candidate] (307.283 ms) : 0, 307283
AppSec [baseline] (57.755 ms) : 0, 57755
AppSec [candidate] (56.484 ms) : 0, 56484
Remote Config [baseline] (625.603 µs) : 0, 626
Remote Config [candidate] (615.536 µs) : 0, 616
Telemetry [baseline] (7.613 ms) : 0, 7613
Telemetry [candidate] (7.436 ms) : 0, 7436
IAST [baseline] (20.761 ms) : 0, 20761
IAST [candidate] (22.204 ms) : 0, 22204
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (807.739 ms) : 0, 807739
BytebuddyAgent [candidate] (803.602 ms) : 0, 803602
GlobalTracer [baseline] (306.526 ms) : 0, 306526
GlobalTracer [candidate] (305.204 ms) : 0, 305204
AppSec [baseline] (58.338 ms) : 0, 58338
AppSec [candidate] (57.738 ms) : 0, 57738
Remote Config [baseline] (623.285 µs) : 0, 623
Remote Config [candidate] (613.656 µs) : 0, 614
Telemetry [baseline] (7.538 ms) : 0, 7538
Telemetry [candidate] (7.436 ms) : 0, 7436
IAST [baseline] (20.719 ms) : 0, 20719
IAST [candidate] (20.376 ms) : 0, 20376
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (812.387 ms) : 0, 812387
BytebuddyAgent [candidate] (808.431 ms) : 0, 808431
GlobalTracer [baseline] (307.629 ms) : 0, 307629
GlobalTracer [candidate] (307.659 ms) : 0, 307659
AppSec [baseline] (58.533 ms) : 0, 58533
AppSec [candidate] (58.326 ms) : 0, 58326
Remote Config [baseline] (628.816 µs) : 0, 629
Remote Config [candidate] (611.139 µs) : 0, 611
Telemetry [baseline] (7.544 ms) : 0, 7544
Telemetry [candidate] (7.465 ms) : 0, 7465
IAST [baseline] (20.799 ms) : 0, 20799
IAST [candidate] (20.394 ms) : 0, 20394
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-08T09:08:56 2024-11-08T09:15:49
git_branch master malvarez/iast-improve-tbv-visitor
git_commit_date 1731055887 1731056157
git_commit_sha 0424969 f2a4220
release_version 1.43.0-SNAPSHOT~04249697bb 1.43.0-SNAPSHOT~f2a4220fb2
start_time 2024-11-08T09:08:43 2024-11-08T09:15:35
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731057696 1731057696
ci_job_id 700187939 700187939
ci_pipeline_id 48537942 48537942
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~f2a4220fb2, baseline=1.43.0-SNAPSHOT~04249697bb
    dateFormat X
    axisFormat %s
section baseline
no_agent (366.029 µs) : 346, 386
.   : milestone, 366,
iast (482.131 µs) : 461, 504
.   : milestone, 482,
iast_FULL (639.597 µs) : 618, 661
.   : milestone, 640,
iast_GLOBAL (507.702 µs) : 487, 529
.   : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (480.937 µs) : 459, 503
.   : milestone, 481,
iast_INACTIVE (435.233 µs) : 415, 456
.   : milestone, 435,
iast_TELEMETRY_OFF (471.314 µs) : 450, 493
.   : milestone, 471,
tracing (439.744 µs) : 419, 461
.   : milestone, 440,
section candidate
no_agent (368.679 µs) : 349, 389
.   : milestone, 369,
iast (480.718 µs) : 460, 502
.   : milestone, 481,
iast_FULL (639.416 µs) : 618, 661
.   : milestone, 639,
iast_GLOBAL (503.853 µs) : 483, 525
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (483.849 µs) : 462, 506
.   : milestone, 484,
iast_INACTIVE (447.852 µs) : 426, 469
.   : milestone, 448,
iast_TELEMETRY_OFF (472.117 µs) : 450, 494
.   : milestone, 472,
tracing (441.819 µs) : 420, 464
.   : milestone, 442,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.029 µs [346.178 µs, 385.88 µs] -
iast 482.131 µs [460.61 µs, 503.652 µs] 116.102 µs (31.7%)
iast_FULL 639.597 µs [618.39 µs, 660.803 µs] 273.568 µs (74.7%)
iast_GLOBAL 507.702 µs [486.581 µs, 528.824 µs] 141.674 µs (38.7%)
iast_HARDCODED_SECRET_DISABLED 480.937 µs [459.345 µs, 502.53 µs] 114.909 µs (31.4%)
iast_INACTIVE 435.233 µs [414.912 µs, 455.553 µs] 69.204 µs (18.9%)
iast_TELEMETRY_OFF 471.314 µs [449.527 µs, 493.102 µs] 105.286 µs (28.8%)
tracing 439.744 µs [418.68 µs, 460.808 µs] 73.715 µs (20.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.679 µs [348.736 µs, 388.622 µs] -
iast 480.718 µs [459.593 µs, 501.843 µs] 112.039 µs (30.4%)
iast_FULL 639.416 µs [618.108 µs, 660.724 µs] 270.737 µs (73.4%)
iast_GLOBAL 503.853 µs [482.835 µs, 524.872 µs] 135.174 µs (36.7%)
iast_HARDCODED_SECRET_DISABLED 483.849 µs [462.18 µs, 505.518 µs] 115.17 µs (31.2%)
iast_INACTIVE 447.852 µs [426.454 µs, 469.251 µs] 79.173 µs (21.5%)
iast_TELEMETRY_OFF 472.117 µs [450.179 µs, 494.056 µs] 103.438 µs (28.1%)
tracing 441.819 µs [420.006 µs, 463.632 µs] 73.14 µs (19.8%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~f2a4220fb2, baseline=1.43.0-SNAPSHOT~04249697bb
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.343 ms) : 1324, 1363
.   : milestone, 1343,
appsec (1.72 ms) : 1695, 1745
.   : milestone, 1720,
appsec_no_iast (1.729 ms) : 1705, 1753
.   : milestone, 1729,
iast (1.476 ms) : 1453, 1499
.   : milestone, 1476,
profiling (1.519 ms) : 1495, 1544
.   : milestone, 1519,
tracing (1.443 ms) : 1419, 1467
.   : milestone, 1443,
section candidate
no_agent (1.321 ms) : 1302, 1340
.   : milestone, 1321,
appsec (1.713 ms) : 1688, 1738
.   : milestone, 1713,
appsec_no_iast (1.728 ms) : 1704, 1752
.   : milestone, 1728,
iast (1.461 ms) : 1439, 1484
.   : milestone, 1461,
profiling (1.476 ms) : 1453, 1499
.   : milestone, 1476,
tracing (1.446 ms) : 1422, 1470
.   : milestone, 1446,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.324 ms, 1.363 ms] -
appsec 1.72 ms [1.695 ms, 1.745 ms] 376.444 µs (28.0%)
appsec_no_iast 1.729 ms [1.705 ms, 1.753 ms] 385.691 µs (28.7%)
iast 1.476 ms [1.453 ms, 1.499 ms] 132.893 µs (9.9%)
profiling 1.519 ms [1.495 ms, 1.544 ms] 176.228 µs (13.1%)
tracing 1.443 ms [1.419 ms, 1.467 ms] 100.164 µs (7.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.321 ms [1.302 ms, 1.34 ms] -
appsec 1.713 ms [1.688 ms, 1.738 ms] 391.908 µs (29.7%)
appsec_no_iast 1.728 ms [1.704 ms, 1.752 ms] 406.952 µs (30.8%)
iast 1.461 ms [1.439 ms, 1.484 ms] 140.129 µs (10.6%)
profiling 1.476 ms [1.453 ms, 1.499 ms] 154.629 µs (11.7%)
tracing 1.446 ms [1.422 ms, 1.47 ms] 124.432 µs (9.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/iast-improve-tbv-visitor
git_commit_date 1731055887 1731056157
git_commit_sha 0424969 f2a4220
release_version 1.43.0-SNAPSHOT~04249697bb 1.43.0-SNAPSHOT~f2a4220fb2
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1731058105 1731058105
ci_job_id 700187940 700187940
ci_pipeline_id 48537942 48537942
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~f2a4220fb2, baseline=1.43.0-SNAPSHOT~04249697bb
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.741 s) : 15741000, 15741000
.   : milestone, 15741000,
appsec (15.235 s) : 15235000, 15235000
.   : milestone, 15235000,
iast (18.9 s) : 18900000, 18900000
.   : milestone, 18900000,
iast_GLOBAL (18.099 s) : 18099000, 18099000
.   : milestone, 18099000,
profiling (14.948 s) : 14948000, 14948000
.   : milestone, 14948000,
tracing (15.134 s) : 15134000, 15134000
.   : milestone, 15134000,
section candidate
no_agent (15.099 s) : 15099000, 15099000
.   : milestone, 15099000,
appsec (15.066 s) : 15066000, 15066000
.   : milestone, 15066000,
iast (18.53 s) : 18530000, 18530000
.   : milestone, 18530000,
iast_GLOBAL (18.402 s) : 18402000, 18402000
.   : milestone, 18402000,
profiling (15.641 s) : 15641000, 15641000
.   : milestone, 15641000,
tracing (15.299 s) : 15299000, 15299000
.   : milestone, 15299000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.741 s [15.741 s, 15.741 s] -
appsec 15.235 s [15.235 s, 15.235 s] -506.0 ms (-3.2%)
iast 18.9 s [18.9 s, 18.9 s] 3.159 s (20.1%)
iast_GLOBAL 18.099 s [18.099 s, 18.099 s] 2.358 s (15.0%)
profiling 14.948 s [14.948 s, 14.948 s] -793.0 ms (-5.0%)
tracing 15.134 s [15.134 s, 15.134 s] -607.0 ms (-3.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.099 s [15.099 s, 15.099 s] -
appsec 15.066 s [15.066 s, 15.066 s] -33.0 ms (-0.2%)
iast 18.53 s [18.53 s, 18.53 s] 3.431 s (22.7%)
iast_GLOBAL 18.402 s [18.402 s, 18.402 s] 3.303 s (21.9%)
profiling 15.641 s [15.641 s, 15.641 s] 542.0 ms (3.6%)
tracing 15.299 s [15.299 s, 15.299 s] 200.0 ms (1.3%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~f2a4220fb2, baseline=1.43.0-SNAPSHOT~04249697bb
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.455 ms) : 1444, 1467
.   : milestone, 1455,
appsec (2.342 ms) : 2300, 2383
.   : milestone, 2342,
iast (2.073 ms) : 2021, 2125
.   : milestone, 2073,
iast_GLOBAL (2.108 ms) : 2056, 2160
.   : milestone, 2108,
profiling (1.94 ms) : 1898, 1982
.   : milestone, 1940,
tracing (1.906 ms) : 1867, 1945
.   : milestone, 1906,
section candidate
no_agent (1.457 ms) : 1446, 1469
.   : milestone, 1457,
appsec (2.31 ms) : 2270, 2350
.   : milestone, 2310,
iast (2.07 ms) : 2018, 2122
.   : milestone, 2070,
iast_GLOBAL (2.111 ms) : 2059, 2163
.   : milestone, 2111,
profiling (2.427 ms) : 2239, 2614
.   : milestone, 2427,
tracing (1.905 ms) : 1866, 1944
.   : milestone, 1905,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.455 ms [1.444 ms, 1.467 ms] -
appsec 2.342 ms [2.3 ms, 2.383 ms] 886.202 µs (60.9%)
iast 2.073 ms [2.021 ms, 2.125 ms] 617.838 µs (42.5%)
iast_GLOBAL 2.108 ms [2.056 ms, 2.16 ms] 652.669 µs (44.8%)
profiling 1.94 ms [1.898 ms, 1.982 ms] 484.68 µs (33.3%)
tracing 1.906 ms [1.867 ms, 1.945 ms] 450.621 µs (31.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.457 ms [1.446 ms, 1.469 ms] -
appsec 2.31 ms [2.27 ms, 2.35 ms] 852.427 µs (58.5%)
iast 2.07 ms [2.018 ms, 2.122 ms] 612.299 µs (42.0%)
iast_GLOBAL 2.111 ms [2.059 ms, 2.163 ms] 653.745 µs (44.9%)
profiling 2.427 ms [2.239 ms, 2.614 ms] 969.26 µs (66.5%)
tracing 1.905 ms [1.866 ms, 1.944 ms] 447.842 µs (30.7%)

@manuel-alvarez-alvarez manuel-alvarez-alvarez marked this pull request as draft November 6, 2024 23:20
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/iast-improve-tbv-visitor branch 2 times, most recently from c60ef02 to d78ea00 Compare November 7, 2024 16:27
@manuel-alvarez-alvarez manuel-alvarez-alvarez changed the title Short-circuit TBV visitor early for types we don't want to visit Add new JPA smoke test to validate IAST visitor Nov 7, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez marked this pull request as ready for review November 7, 2024 16:30
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested a review from a team as a code owner November 7, 2024 16:30
@manuel-alvarez-alvarez manuel-alvarez-alvarez added the tag: no release notes Changes to exclude from release notes label Nov 7, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/iast-improve-tbv-visitor branch from d78ea00 to 4ea5693 Compare November 7, 2024 16:42
@manuel-alvarez-alvarez manuel-alvarez-alvarez changed the title Add new JPA smoke test to validate IAST visitor Add new JPA smoke test to validate the IAST visitor Nov 7, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/iast-improve-tbv-visitor branch from 4ea5693 to f2a4220 Compare November 8, 2024 08:56
amarziali
amarziali approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition

@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit 3497807 into master Nov 13, 2024
101 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/iast-improve-tbv-visitor branch November 13, 2024 08:54
@github-actions github-actions bot added this to the 1.43.0 milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola smola approved these changes

@amarziali amarziali amarziali approved these changes

@ValentinZakharov ValentinZakharov Awaiting requested review from ValentinZakharov ValentinZakharov was automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: asm iast Application Security Management (IAST) comp: testing Testing tag: no release notes Changes to exclude from release notes
Projects
None yet
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.
3 participants
@manuel-alvarez-alvarez @smola @amarziali