Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix /info endpoint in smoke tests #7930

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Fix /info endpoint in smoke tests #7930

merged 1 commit into from
Nov 11, 2024

Conversation

smola
Copy link
Member

@smola smola commented Nov 11, 2024 •
edited
Loading

What Does This Do

#7257 introduced the /info endpoint for the mock agent in smoke-tests, but it was malformed, leading to logged exceptions:

[dd.trace 2024-11-11 16:38:35:249 +0100] [main] DEBUG datadog.communication.ddagent.DDAgentFeaturesDiscovery - Error parsing trace agent /info response
com.squareup.moshi.JsonEncodingException: Use JsonReader.setLenient(true) to accept malformed JSON at path $.endpoints[3]
        at com.squareup.moshi.JsonReader.syntaxError(JsonReader.java:243)
        at com.squareup.moshi.JsonUtf8Reader.checkLenient(JsonUtf8Reader.java:1152)
        at com.squareup.moshi.JsonUtf8Reader.doPeek(JsonUtf8Reader.java:349)
        at com.squareup.moshi.JsonUtf8Reader.hasNext(JsonUtf8Reader.java:197)
        at com.squareup.moshi.CollectionJsonAdapter.fromJson(CollectionJsonAdapter.java:80)
        at com.squareup.moshi.CollectionJsonAdapter$2.fromJson(CollectionJsonAdapter.java:55)
        at com.squareup.moshi.internal.NullSafeJsonAdapter.fromJson(NullSafeJsonAdapter.java:41)
        at com.squareup.moshi.StandardJsonAdapters$ObjectJsonAdapter.fromJson(StandardJsonAdapters.java:344)
        at com.squareup.moshi.internal.NullSafeJsonAdapter.fromJson(NullSafeJsonAdapter.java:41)
        at com.squareup.moshi.MapJsonAdapter.fromJson(MapJsonAdapter.java:73)
        at com.squareup.moshi.MapJsonAdapter.fromJson(MapJsonAdapter.java:30)
        at com.squareup.moshi.internal.NullSafeJsonAdapter.fromJson(NullSafeJsonAdapter.java:41)
        at com.squareup.moshi.JsonAdapter.fromJson(JsonAdapter.java:51)
        at datadog.communication.ddagent.DDAgentFeaturesDiscovery.processInfoResponse(DDAgentFeaturesDiscovery.java:212)
[...]

Also modified AsmStandaloneBillingSmokeTest.groovy to stop relying on TestHttpServer.last, which is flaky/failing if a non-tracing request to the agent gets sent in the middle.

Added metrics endpoint to keep everything closer to prod.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@smola smola requested a review from a team as a code owner November 11, 2024 15:45
@smola smola requested a review from nayeem-kamal November 11, 2024 15:45
@smola smola added comp: testing Testing tag: no release notes Changes to exclude from release notes labels Nov 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@pr-commenter
Copy link

pr-commenter bot commented Nov 11, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/fix-smoke-tests-info-endpoint
git_commit_date 1731340376 1731344122
git_commit_sha 31bfaf7 f2a4989
release_version 1.43.0-SNAPSHOT~31bfaf7217 1.43.0-SNAPSHOT~f2a4989e0d
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731346410 1731346410
ci_job_id 702473166 702473166
ci_pipeline_id 48719842 48719842
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~f2a4989e0d, baseline=1.43.0-SNAPSHOT~31bfaf7217

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084367
Total [baseline] (8.587 s) : 0, 8587219
Agent [candidate] (1.085 s) : 0, 1085049
Total [candidate] (8.584 s) : 0, 8584352
section iast
Agent [baseline] (1.218 s) : 0, 1217575
Total [baseline] (9.216 s) : 0, 9216134
Agent [candidate] (1.217 s) : 0, 1217268
Total [candidate] (9.19 s) : 0, 9189842
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.21 s) : 0, 1209918
Total [baseline] (9.146 s) : 0, 9146347
Agent [candidate] (1.22 s) : 0, 1219952
Total [candidate] (9.15 s) : 0, 9149584
section iast_TELEMETRY_OFF
Agent [baseline] (1.215 s) : 0, 1214830
Total [baseline] (9.165 s) : 0, 9164927
Agent [candidate] (1.214 s) : 0, 1213943
Total [candidate] (9.17 s) : 0, 9170408
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent iast 1.218 s 133.208 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.21 s 125.551 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.215 s 130.463 ms (12.0%)
Total tracing 8.587 s -
Total iast 9.216 s 628.914 ms (7.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.146 s 559.128 ms (6.5%)
Total iast_TELEMETRY_OFF 9.165 s 577.708 ms (6.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.085 s -
Agent iast 1.217 s 132.219 ms (12.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.22 s 134.903 ms (12.4%)
Agent iast_TELEMETRY_OFF 1.214 s 128.893 ms (11.9%)
Total tracing 8.584 s -
Total iast 9.19 s 605.49 ms (7.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.15 s 565.232 ms (6.6%)
Total iast_TELEMETRY_OFF 9.17 s 586.056 ms (6.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~f2a4989e0d, baseline=1.43.0-SNAPSHOT~31bfaf7217

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.766 ms) : 0, 688766
BytebuddyAgent [candidate] (687.764 ms) : 0, 687764
GlobalTracer [baseline] (316.615 ms) : 0, 316615
GlobalTracer [candidate] (316.216 ms) : 0, 316216
AppSec [baseline] (54.437 ms) : 0, 54437
AppSec [candidate] (54.457 ms) : 0, 54457
Remote Config [baseline] (685.134 µs) : 0, 685
Remote Config [candidate] (678.136 µs) : 0, 678
Telemetry [baseline] (10.027 ms) : 0, 10027
Telemetry [candidate] (12.141 ms) : 0, 12141
section iast
BytebuddyAgent [baseline] (808.689 ms) : 0, 808689
BytebuddyAgent [candidate] (808.758 ms) : 0, 808758
GlobalTracer [baseline] (307.209 ms) : 0, 307209
GlobalTracer [candidate] (307.317 ms) : 0, 307317
AppSec [baseline] (56.848 ms) : 0, 56848
AppSec [candidate] (56.617 ms) : 0, 56617
IAST [baseline] (22.631 ms) : 0, 22631
IAST [candidate] (22.452 ms) : 0, 22452
Remote Config [baseline] (634.308 µs) : 0, 634
Remote Config [candidate] (630.299 µs) : 0, 630
Telemetry [baseline] (7.664 ms) : 0, 7664
Telemetry [candidate] (7.626 ms) : 0, 7626
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (803.488 ms) : 0, 803488
BytebuddyAgent [candidate] (810.718 ms) : 0, 810718
GlobalTracer [baseline] (305.865 ms) : 0, 305865
GlobalTracer [candidate] (307.317 ms) : 0, 307317
AppSec [baseline] (55.486 ms) : 0, 55486
AppSec [candidate] (58.468 ms) : 0, 58468
IAST [baseline] (22.292 ms) : 0, 22292
IAST [candidate] (21.177 ms) : 0, 21177
Remote Config [baseline] (618.784 µs) : 0, 619
Remote Config [candidate] (637.956 µs) : 0, 638
Telemetry [baseline] (8.366 ms) : 0, 8366
Telemetry [candidate] (7.719 ms) : 0, 7719
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (806.704 ms) : 0, 806704
BytebuddyAgent [candidate] (806.563 ms) : 0, 806563
GlobalTracer [baseline] (307.659 ms) : 0, 307659
GlobalTracer [candidate] (306.488 ms) : 0, 306488
AppSec [baseline] (58.37 ms) : 0, 58370
AppSec [candidate] (57.945 ms) : 0, 57945
IAST [baseline] (20.224 ms) : 0, 20224
IAST [candidate] (20.358 ms) : 0, 20358
Remote Config [baseline] (605.643 µs) : 0, 606
Remote Config [candidate] (608.045 µs) : 0, 608
Telemetry [baseline] (7.392 ms) : 0, 7392
Telemetry [candidate] (8.147 ms) : 0, 8147
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~f2a4989e0d, baseline=1.43.0-SNAPSHOT~31bfaf7217

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.082 s) : 0, 1082061
Total [baseline] (10.461 s) : 0, 10460815
Agent [candidate] (1.094 s) : 0, 1094420
Total [candidate] (10.461 s) : 0, 10460852
section appsec
Agent [baseline] (1.221 s) : 0, 1221045
Total [baseline] (10.7 s) : 0, 10700049
Agent [candidate] (1.227 s) : 0, 1226871
Total [candidate] (10.717 s) : 0, 10717091
section iast
Agent [baseline] (1.211 s) : 0, 1211485
Total [baseline] (10.983 s) : 0, 10982562
Agent [candidate] (1.217 s) : 0, 1216591
Total [candidate] (10.964 s) : 0, 10964237
section profiling
Agent [baseline] (1.28 s) : 0, 1279682
Total [baseline] (10.738 s) : 0, 10738338
Agent [candidate] (1.289 s) : 0, 1289166
Total [candidate] (10.791 s) : 0, 10790909
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.082 s -
Agent appsec 1.221 s 138.984 ms (12.8%)
Agent iast 1.211 s 129.424 ms (12.0%)
Agent profiling 1.28 s 197.621 ms (18.3%)
Total tracing 10.461 s -
Total appsec 10.7 s 239.234 ms (2.3%)
Total iast 10.983 s 521.748 ms (5.0%)
Total profiling 10.738 s 277.523 ms (2.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.094 s -
Agent appsec 1.227 s 132.452 ms (12.1%)
Agent iast 1.217 s 122.172 ms (11.2%)
Agent profiling 1.289 s 194.746 ms (17.8%)
Total tracing 10.461 s -
Total appsec 10.717 s 256.239 ms (2.4%)
Total iast 10.964 s 503.385 ms (4.8%)
Total profiling 10.791 s 330.058 ms (3.2%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~f2a4989e0d, baseline=1.43.0-SNAPSHOT~31bfaf7217

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.121 ms) : 0, 687121
BytebuddyAgent [candidate] (693.947 ms) : 0, 693947
GlobalTracer [baseline] (316.114 ms) : 0, 316114
GlobalTracer [candidate] (319.136 ms) : 0, 319136
AppSec [baseline] (54.256 ms) : 0, 54256
AppSec [candidate] (54.701 ms) : 0, 54701
Remote Config [baseline] (682.637 µs) : 0, 683
Remote Config [candidate] (681.983 µs) : 0, 682
Telemetry [baseline] (10.133 ms) : 0, 10133
Telemetry [candidate] (12.07 ms) : 0, 12070
section appsec
BytebuddyAgent [baseline] (707.11 ms) : 0, 707110
BytebuddyAgent [candidate] (709.998 ms) : 0, 709998
GlobalTracer [baseline] (314.727 ms) : 0, 314727
GlobalTracer [candidate] (316.174 ms) : 0, 316174
AppSec [baseline] (166.063 ms) : 0, 166063
AppSec [candidate] (168.336 ms) : 0, 168336
IAST [baseline] (21.04 ms) : 0, 21040
IAST [candidate] (20.678 ms) : 0, 20678
Remote Config [baseline] (642.292 µs) : 0, 642
Remote Config [candidate] (644.779 µs) : 0, 645
Telemetry [baseline] (8.208 ms) : 0, 8208
Telemetry [candidate] (7.542 ms) : 0, 7542
section iast
BytebuddyAgent [baseline] (805.069 ms) : 0, 805069
BytebuddyAgent [candidate] (809.171 ms) : 0, 809171
GlobalTracer [baseline] (306.056 ms) : 0, 306056
GlobalTracer [candidate] (306.994 ms) : 0, 306994
AppSec [baseline] (57.613 ms) : 0, 57613
AppSec [candidate] (57.748 ms) : 0, 57748
IAST [baseline] (20.803 ms) : 0, 20803
IAST [candidate] (20.662 ms) : 0, 20662
Remote Config [baseline] (636.783 µs) : 0, 637
Remote Config [candidate] (643.831 µs) : 0, 644
Telemetry [baseline] (7.534 ms) : 0, 7534
Telemetry [candidate] (7.469 ms) : 0, 7469
section profiling
BytebuddyAgent [baseline] (680.074 ms) : 0, 680074
BytebuddyAgent [candidate] (685.78 ms) : 0, 685780
GlobalTracer [baseline] (400.767 ms) : 0, 400767
GlobalTracer [candidate] (402.625 ms) : 0, 402625
AppSec [baseline] (54.808 ms) : 0, 54808
AppSec [candidate] (55.084 ms) : 0, 55084
Remote Config [baseline] (666.759 µs) : 0, 667
Remote Config [candidate] (677.406 µs) : 0, 677
Telemetry [baseline] (13.423 ms) : 0, 13423
Telemetry [candidate] (12.665 ms) : 0, 12665
ProfilingAgent [baseline] (90.866 ms) : 0, 90866
ProfilingAgent [candidate] (93.049 ms) : 0, 93049
Profiling [baseline] (90.89 ms) : 0, 90890
Profiling [candidate] (93.073 ms) : 0, 93073
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-11T17:03:42 2024-11-11T17:10:37
git_branch master smola/fix-smoke-tests-info-endpoint
git_commit_date 1731340376 1731344122
git_commit_sha 31bfaf7 f2a4989
release_version 1.43.0-SNAPSHOT~31bfaf7217 1.43.0-SNAPSHOT~f2a4989e0d
start_time 2024-11-11T17:03:29 2024-11-11T17:10:23
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731345386 1731345386
ci_job_id 702473167 702473167
ci_pipeline_id 48719842 48719842
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~f2a4989e0d, baseline=1.43.0-SNAPSHOT~31bfaf7217
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.207 µs) : 353, 392
.   : milestone, 372,
iast (484.438 µs) : 463, 506
.   : milestone, 484,
iast_FULL (638.54 µs) : 617, 660
.   : milestone, 639,
iast_GLOBAL (514.724 µs) : 494, 536
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (485.476 µs) : 465, 506
.   : milestone, 485,
iast_INACTIVE (445.713 µs) : 425, 467
.   : milestone, 446,
iast_TELEMETRY_OFF (475.788 µs) : 454, 497
.   : milestone, 476,
tracing (453.016 µs) : 429, 477
.   : milestone, 453,
section candidate
no_agent (374.408 µs) : 354, 394
.   : milestone, 374,
iast (488.632 µs) : 467, 510
.   : milestone, 489,
iast_FULL (641.193 µs) : 620, 663
.   : milestone, 641,
iast_GLOBAL (520.036 µs) : 498, 542
.   : milestone, 520,
iast_HARDCODED_SECRET_DISABLED (491.17 µs) : 470, 512
.   : milestone, 491,
iast_INACTIVE (447.343 µs) : 426, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (478.991 µs) : 458, 500
.   : milestone, 479,
tracing (439.626 µs) : 419, 460
.   : milestone, 440,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.207 µs [352.508 µs, 391.906 µs] -
iast 484.438 µs [463.307 µs, 505.568 µs] 112.231 µs (30.2%)
iast_FULL 638.54 µs [617.206 µs, 659.875 µs] 266.334 µs (71.6%)
iast_GLOBAL 514.724 µs [493.592 µs, 535.855 µs] 142.517 µs (38.3%)
iast_HARDCODED_SECRET_DISABLED 485.476 µs [464.521 µs, 506.43 µs] 113.269 µs (30.4%)
iast_INACTIVE 445.713 µs [424.914 µs, 466.512 µs] 73.506 µs (19.7%)
iast_TELEMETRY_OFF 475.788 µs [454.48 µs, 497.096 µs] 103.581 µs (27.8%)
tracing 453.016 µs [428.619 µs, 477.413 µs] 80.809 µs (21.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.408 µs [354.449 µs, 394.367 µs] -
iast 488.632 µs [467.257 µs, 510.006 µs] 114.224 µs (30.5%)
iast_FULL 641.193 µs [619.862 µs, 662.524 µs] 266.785 µs (71.3%)
iast_GLOBAL 520.036 µs [498.162 µs, 541.909 µs] 145.628 µs (38.9%)
iast_HARDCODED_SECRET_DISABLED 491.17 µs [469.92 µs, 512.419 µs] 116.762 µs (31.2%)
iast_INACTIVE 447.343 µs [426.294 µs, 468.391 µs] 72.935 µs (19.5%)
iast_TELEMETRY_OFF 478.991 µs [457.522 µs, 500.46 µs] 104.583 µs (27.9%)
tracing 439.626 µs [419.24 µs, 460.013 µs] 65.218 µs (17.4%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~f2a4989e0d, baseline=1.43.0-SNAPSHOT~31bfaf7217
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.346 ms) : 1326, 1365
.   : milestone, 1346,
appsec (1.73 ms) : 1705, 1754
.   : milestone, 1730,
appsec_no_iast (1.742 ms) : 1718, 1765
.   : milestone, 1742,
iast (1.47 ms) : 1447, 1492
.   : milestone, 1470,
profiling (1.477 ms) : 1454, 1499
.   : milestone, 1477,
tracing (1.476 ms) : 1453, 1500
.   : milestone, 1476,
section candidate
no_agent (1.344 ms) : 1325, 1363
.   : milestone, 1344,
appsec (1.731 ms) : 1708, 1754
.   : milestone, 1731,
appsec_no_iast (1.731 ms) : 1707, 1755
.   : milestone, 1731,
iast (1.484 ms) : 1462, 1507
.   : milestone, 1484,
profiling (1.481 ms) : 1458, 1503
.   : milestone, 1481,
tracing (1.477 ms) : 1453, 1500
.   : milestone, 1477,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.326 ms, 1.365 ms] -
appsec 1.73 ms [1.705 ms, 1.754 ms] 384.086 µs (28.5%)
appsec_no_iast 1.742 ms [1.718 ms, 1.765 ms] 395.821 µs (29.4%)
iast 1.47 ms [1.447 ms, 1.492 ms] 123.809 µs (9.2%)
profiling 1.477 ms [1.454 ms, 1.499 ms] 130.915 µs (9.7%)
tracing 1.476 ms [1.453 ms, 1.5 ms] 130.8 µs (9.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.344 ms [1.325 ms, 1.363 ms] -
appsec 1.731 ms [1.708 ms, 1.754 ms] 386.867 µs (28.8%)
appsec_no_iast 1.731 ms [1.707 ms, 1.755 ms] 386.247 µs (28.7%)
iast 1.484 ms [1.462 ms, 1.507 ms] 140.12 µs (10.4%)
profiling 1.481 ms [1.458 ms, 1.503 ms] 136.361 µs (10.1%)
tracing 1.477 ms [1.453 ms, 1.5 ms] 132.279 µs (9.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/fix-smoke-tests-info-endpoint
git_commit_date 1731340376 1731344122
git_commit_sha 31bfaf7 f2a4989
release_version 1.43.0-SNAPSHOT~31bfaf7217 1.43.0-SNAPSHOT~f2a4989e0d
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1731345915 1731345915
ci_job_id 702473168 702473168
ci_pipeline_id 48719842 48719842
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~f2a4989e0d, baseline=1.43.0-SNAPSHOT~31bfaf7217
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1481
.   : milestone, 1469,
appsec (2.322 ms) : 2281, 2363
.   : milestone, 2322,
iast (2.067 ms) : 2015, 2119
.   : milestone, 2067,
iast_GLOBAL (2.108 ms) : 2056, 2159
.   : milestone, 2108,
profiling (1.926 ms) : 1885, 1967
.   : milestone, 1926,
tracing (1.918 ms) : 1878, 1957
.   : milestone, 1918,
section candidate
no_agent (1.468 ms) : 1456, 1480
.   : milestone, 1468,
appsec (2.327 ms) : 2285, 2368
.   : milestone, 2327,
iast (2.068 ms) : 2016, 2121
.   : milestone, 2068,
iast_GLOBAL (2.118 ms) : 2066, 2171
.   : milestone, 2118,
profiling (1.941 ms) : 1899, 1983
.   : milestone, 1941,
tracing (1.922 ms) : 1882, 1962
.   : milestone, 1922,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.457 ms, 1.481 ms] -
appsec 2.322 ms [2.281 ms, 2.363 ms] 852.54 µs (58.0%)
iast 2.067 ms [2.015 ms, 2.119 ms] 598.069 µs (40.7%)
iast_GLOBAL 2.108 ms [2.056 ms, 2.159 ms] 638.532 µs (43.5%)
profiling 1.926 ms [1.885 ms, 1.967 ms] 456.873 µs (31.1%)
tracing 1.918 ms [1.878 ms, 1.957 ms] 448.563 µs (30.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.456 ms, 1.48 ms] -
appsec 2.327 ms [2.285 ms, 2.368 ms] 858.798 µs (58.5%)
iast 2.068 ms [2.016 ms, 2.121 ms] 600.426 µs (40.9%)
iast_GLOBAL 2.118 ms [2.066 ms, 2.171 ms] 650.406 µs (44.3%)
profiling 1.941 ms [1.899 ms, 1.983 ms] 472.945 µs (32.2%)
tracing 1.922 ms [1.882 ms, 1.962 ms] 454.139 µs (30.9%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~f2a4989e0d, baseline=1.43.0-SNAPSHOT~31bfaf7217
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.815 s) : 15815000, 15815000
.   : milestone, 15815000,
appsec (15.166 s) : 15166000, 15166000
.   : milestone, 15166000,
iast (18.497 s) : 18497000, 18497000
.   : milestone, 18497000,
iast_GLOBAL (18.293 s) : 18293000, 18293000
.   : milestone, 18293000,
profiling (15.049 s) : 15049000, 15049000
.   : milestone, 15049000,
tracing (15.199 s) : 15199000, 15199000
.   : milestone, 15199000,
section candidate
no_agent (15.487 s) : 15487000, 15487000
.   : milestone, 15487000,
appsec (15.319 s) : 15319000, 15319000
.   : milestone, 15319000,
iast (19.0 s) : 19000000, 19000000
.   : milestone, 19000000,
iast_GLOBAL (18.346 s) : 18346000, 18346000
.   : milestone, 18346000,
profiling (14.935 s) : 14935000, 14935000
.   : milestone, 14935000,
tracing (15.315 s) : 15315000, 15315000
.   : milestone, 15315000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.815 s [15.815 s, 15.815 s] -
appsec 15.166 s [15.166 s, 15.166 s] -649.0 ms (-4.1%)
iast 18.497 s [18.497 s, 18.497 s] 2.682 s (17.0%)
iast_GLOBAL 18.293 s [18.293 s, 18.293 s] 2.478 s (15.7%)
profiling 15.049 s [15.049 s, 15.049 s] -766.0 ms (-4.8%)
tracing 15.199 s [15.199 s, 15.199 s] -616.0 ms (-3.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.487 s [15.487 s, 15.487 s] -
appsec 15.319 s [15.319 s, 15.319 s] -168.0 ms (-1.1%)
iast 19.0 s [19.0 s, 19.0 s] 3.513 s (22.7%)
iast_GLOBAL 18.346 s [18.346 s, 18.346 s] 2.859 s (18.5%)
profiling 14.935 s [14.935 s, 14.935 s] -552.0 ms (-3.6%)
tracing 15.315 s [15.315 s, 15.315 s] -172.0 ms (-1.1%)

@smola smola force-pushed the smola/fix-smoke-tests-info-endpoint branch from 28e4e17 to f2a4989 Compare November 11, 2024 16:55
mcculls
mcculls approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@mcculls mcculls left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@smola smola merged commit 44ac386 into master Nov 11, 2024
103 checks passed
@smola smola deleted the smola/fix-smoke-tests-info-endpoint branch November 11, 2024 18:53
@github-actions github-actions bot added this to the 1.43.0 milestone Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcculls mcculls mcculls approved these changes

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: testing Testing tag: no release notes Changes to exclude from release notes
Projects
None yet
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.
2 participants
@smola @mcculls